Bug 78893 – [GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

I used 'done' for consistency with GtkPrintOperation, but this signal is not exactly the same. We use ::finished and ::failed in other objects like WebKitDownload, so I think it's better to use finished for consistency.

[Carlos Garcia Campos]

Created attachment 127578 [details]
Patch

It's not emitted anynmore when the print dialog has been cancelled. Since it's not possible to know whether the print dialog was cancelled or not, the enum WebKitPrintOperationResponse has been added, with Print and Cancel values, and it's used as return value of webkit_print_operation_run_dialog(). I've used an enum instead of a boolean just in case we add WEBKIT_PRINT_OPERATION_RESPONSE_PREVIEW in the future

[Gustavo Noronha (kov)]

Comment on attachment 127578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127578&action=review

Looks good to me; also having an enum allows us to expand this API more easily, though I think it'll probably not need too much change in the future after it settles =)

> Source/WebKit2/ChangeLog:18
> +        (webkitPrintOperationRunDialogWin32): Dittoo.

s/oo/o/

> Source/WebKit2/ChangeLog:20
> +        (webkitPrintOperationRunDialogForFrame): Do ot emit finished if

s/ot/not/

[Carlos Garcia Campos]

Committed r108069: <http://trac.webkit.org/changeset/108069>