Bug 78885 - perf-o-matic needs model unit tests
Summary: perf-o-matic needs model unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-02-17 02:00 PST by Ryosuke Niwa
Modified: 2012-02-17 10:47 PST (History)
2 users (show)

See Also:

Attachments
Adds some unit tests (24.10 KB, patch)
2012-02-17 02:05 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-02-17 02:00:31 PST 
We need some tests.
Comment 1 Ryosuke Niwa 2012-02-17 02:05:34 PST 
Created attachment 127554 [details]
Adds some unit tests
Comment 2 Adam Barth 2012-02-17 10:41:57 PST 
Comment on attachment 127554 [details]
Adds some unit tests

View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review

> Websites/webkit-perf.appspot.com/models_unittest.py:272
> +if __name__ == '__main__':
> +    unittest.main()

Is this test wired into test-webkitpy?  We have some tests from the QueueStatusServer wired in if you want to see how it's done.
Comment 3 Ryosuke Niwa 2012-02-17 10:43:39 PST 
(In reply to comment #2)
> (From update of attachment 127554 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review
> 
> > Websites/webkit-perf.appspot.com/models_unittest.py:272
> > +if __name__ == '__main__':
> > +    unittest.main()
> 
> Is this test wired into test-webkitpy?  We have some tests from the QueueStatusServer wired in if you want to see how it's done.

Not at the moment. I think we want to move the entire directory into Tools first if we're going to do that.
Comment 4 Ryosuke Niwa 2012-02-17 10:47:09 PST 
Comment on attachment 127554 [details]
Adds some unit tests

Clearing flags on attachment: 127554

Committed r108094: <http://trac.webkit.org/changeset/108094>
Comment 5 Ryosuke Niwa 2012-02-17 10:47:20 PST 
All reviewed patches have been landed.  Closing bug.