Bug 78868 - Move textDirectionForSelection from Editor to EditingStyle
Summary: Move textDirectionForSelection from Editor to EditingStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 19:25 PST by Ryosuke Niwa
Modified: 2012-02-17 15:57 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.86 KB, patch)
2012-02-16 19:26 PST, Ryosuke Niwa
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-02-16 19:25:29 PST
Move textDirectionForSelection from Editor to EditingStyle
Comment 1 Ryosuke Niwa 2012-02-16 19:26:35 PST
Created attachment 127499 [details]
Patch
Comment 2 Ryosuke Niwa 2012-02-16 19:29:43 PST
Per discussion we had on Tue, I'm moving all editing code's dependency on CSStyleDeclaration into EditingStyle so that we can get rid of them more easily.
Comment 3 Enrica Casucci 2012-02-17 12:57:04 PST
Comment on attachment 127499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127499&action=review

Looks good to me. Please make sure you don't check in the changes to the project. File.

> Source/WebCore/ChangeLog:11
> +        * WebCore.xcodeproj/project.pbxproj:

This should be removed

> Source/WebCore/ChangeLog:16
> +        (EditingStyle):

I normally remove these lines, since they don't add any valuable information.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7388
> +		1C435CD514E8545B004E10EA /* Inspector-1.0.json */ = {isa = PBXFileReference; lastKnownFileType = text; path = "Inspector-1.0.json"; sourceTree = "<group>"; };

I don't think this is part of this patch.
Comment 4 Ryosuke Niwa 2012-02-17 15:57:13 PST
Committed r108137: <http://trac.webkit.org/changeset/108137>