Bug 78865 - [Chromium] Include TestShellLinux.cpp in the build for Android
Summary: [Chromium] Include TestShellLinux.cpp in the build for Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 17:49 PST by Peter Beverloo
Modified: 2012-02-17 10:10 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-02-16 17:52 PST, Peter Beverloo
no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2012-02-17 09:26 PST, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-02-16 17:49:45 PST
[Chromium] Include TestShellLinux.cpp in the build for Android
Comment 1 Peter Beverloo 2012-02-16 17:52:14 PST
Created attachment 127486 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-16 18:29:10 PST
Comment on attachment 127486 [details]
Patch

Wow, it's still called TestShell... amazing. :)
Comment 3 WebKit Review Bot 2012-02-16 21:00:06 PST
Comment on attachment 127486 [details]
Patch

Rejecting attachment 127486 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11535428
Comment 4 Peter Beverloo 2012-02-16 22:10:59 PST
Oh wow, how did I manage to rip that out. Sorry, I'll fix and land in the morning.
Comment 5 Peter Beverloo 2012-02-17 09:26:47 PST
Created attachment 127605 [details]
Patch
Comment 6 Peter Beverloo 2012-02-17 09:27:38 PST
Comment on attachment 127605 [details]
Patch

Pushing this on the CQ.
Comment 7 WebKit Review Bot 2012-02-17 10:10:06 PST
Comment on attachment 127605 [details]
Patch

Clearing flags on attachment: 127605

Committed r108090: <http://trac.webkit.org/changeset/108090>
Comment 8 WebKit Review Bot 2012-02-17 10:10:10 PST
All reviewed patches have been landed.  Closing bug.