Bug 78852 - Add FractionalLayoutSize for sub-pixel layout
Summary: Add FractionalLayoutSize for sub-pixel layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 76571 78913 78924
  Show dependency treegraph
 
Reported: 2012-02-16 15:38 PST by Emil A Eklund
Modified: 2012-02-17 17:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (23.56 KB, patch)
2012-02-16 17:43 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch (22.77 KB, patch)
2012-02-17 11:25 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (21.98 KB, patch)
2012-02-17 12:52 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-16 15:38:00 PST
Splitting bug 76571 into one bug/patch per class to make it easier to review.
Comment 1 Emil A Eklund 2012-02-16 17:43:04 PST
Created attachment 127482 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-16 17:45:38 PST
Comment on attachment 127482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808
> -				BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */,
> +				144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */,

Huh?
Comment 3 Emil A Eklund 2012-02-16 18:09:52 PST
(In reply to comment #2)
> (From update of attachment 127482 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808
> > -				BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */,
> > +				144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */,
> 
> Huh?

We got the fingerprint/numeric id wrong. I think the old value is for when the file was named AppUnit.h.
Comment 4 Emil A Eklund 2012-02-17 11:25:20 PST
Created attachment 127617 [details]
Patch
Comment 5 Eric Seidel (no email) 2012-02-17 12:01:24 PST
Comment on attachment 127617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127617&action=review

> Source/WebCore/platform/graphics/FractionalLayoutSize.h:70
> +        m_width = static_cast<int>(static_cast<float>(m_width) * scale);
> +        m_height = static_cast<int>(static_cast<float>(m_height) * scale);

I'm surprised you need the statis_cast<float>.  Wont float * int return a float anyway?
Comment 6 Emil A Eklund 2012-02-17 12:26:03 PST
(In reply to comment #5)
> I'm surprised you need the statis_cast<float>.  Wont float * int return a float anyway?

As was I but we get a compiler warning about ambiguity without the cast.
Comment 7 Emil A Eklund 2012-02-17 12:52:50 PST
Created attachment 127632 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-02-17 14:37:56 PST
Comment on attachment 127632 [details]
Patch for landing

Rejecting attachment 127632 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e/WebCore/platform/graphics/FloatPoint.cpp
patching file Source/WebCore/platform/graphics/FloatPoint.h
patching file Source/WebCore/platform/graphics/FloatSize.cpp
patching file Source/WebCore/platform/graphics/FloatSize.h
patching file Source/WebCore/platform/graphics/FractionalLayoutSize.cpp
patching file Source/WebCore/platform/graphics/FractionalLayoutSize.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11541519
Comment 9 Emil A Eklund 2012-02-17 15:07:57 PST
Committed r108131: <http://trac.webkit.org/changeset/108131>