Bug 78852 – Add FractionalLayoutSize for sub-pixel layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Splitting bug 76571 into one bug/patch per class to make it easier to review.

[Emil A Eklund]

Created attachment 127482 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 127482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808
> -				BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */,
> +				144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */,

Huh?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 127482 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808
> > -				BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */,
> > +				144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */,
> 
> Huh?

We got the fingerprint/numeric id wrong. I think the old value is for when the file was named AppUnit.h.

[Emil A Eklund]

Created attachment 127617 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 127617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127617&action=review

> Source/WebCore/platform/graphics/FractionalLayoutSize.h:70
> +        m_width = static_cast<int>(static_cast<float>(m_width) * scale);
> +        m_height = static_cast<int>(static_cast<float>(m_height) * scale);

I'm surprised you need the statis_cast<float>.  Wont float * int return a float anyway?

[Emil A Eklund]

(In reply to comment #5)
> I'm surprised you need the statis_cast<float>.  Wont float * int return a float anyway?

As was I but we get a compiler warning about ambiguity without the cast.

[Emil A Eklund]

Created attachment 127632 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 127632 [details]
Patch for landing

Rejecting attachment 127632 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e/WebCore/platform/graphics/FloatPoint.cpp
patching file Source/WebCore/platform/graphics/FloatPoint.h
patching file Source/WebCore/platform/graphics/FloatSize.cpp
patching file Source/WebCore/platform/graphics/FloatSize.h
patching file Source/WebCore/platform/graphics/FractionalLayoutSize.cpp
patching file Source/WebCore/platform/graphics/FractionalLayoutSize.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11541519

[Emil A Eklund]

Committed r108131: <http://trac.webkit.org/changeset/108131>