Bug 78851 – [Chromium] Texture eviction doesn't show up in traces.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Reveman]

Add TextureManager::evictTexture() function with TRACE statement so that texture eviction shows up in traces.

[David Reveman]

Created attachment 127455 [details]
Patch

[Nat Duca]

Comment on attachment 127455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review

LGTM with nit

> Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194
> +    TRACE_EVENT("TextureManager::evictTexture", this, 0);

Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces.

[David Reveman]

Created attachment 127624 [details]
Patch

[David Reveman]

(In reply to comment #2)
> (From update of attachment 127455 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review
> 
> LGTM with nit
> 
> > Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194
> > +    TRACE_EVENT("TextureManager::evictTexture", this, 0);
> 
> Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces.

Yes, the conditional trace in evictTexture() is less than ideal. I kept the evictTexture() function as I'd like to distinguish between a texture being removed normally and from eviction but I instead made the function a simple wrapper around removeTexture().

[WebKit Review Bot]

Comment on attachment 127624 [details]
Patch

Clearing flags on attachment: 127624

Committed r108124: <http://trac.webkit.org/changeset/108124>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.