Bug 78851 - [Chromium] Texture eviction doesn't show up in traces.
Summary: [Chromium] Texture eviction doesn't show up in traces.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 15:27 PST by David Reveman
Modified: 2012-02-17 14:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2012-02-16 15:30 PST, David Reveman
no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2012-02-17 11:44 PST, David Reveman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2012-02-16 15:27:43 PST
Add TextureManager::evictTexture() function with TRACE statement so that texture eviction shows up in traces.
Comment 1 David Reveman 2012-02-16 15:30:23 PST
Created attachment 127455 [details]
Patch
Comment 2 Nat Duca 2012-02-16 20:36:50 PST
Comment on attachment 127455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review

LGTM with nit

> Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194
> +    TRACE_EVENT("TextureManager::evictTexture", this, 0);

Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces.
Comment 3 David Reveman 2012-02-17 11:44:51 PST
Created attachment 127624 [details]
Patch
Comment 4 David Reveman 2012-02-17 11:50:24 PST
(In reply to comment #2)
> (From update of attachment 127455 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127455&action=review
> 
> LGTM with nit
> 
> > Source/WebCore/platform/graphics/chromium/TextureManager.cpp:194
> > +    TRACE_EVENT("TextureManager::evictTexture", this, 0);
> 
> Might be better to put the trace in "removeTexture" to avoid confusion over TextureManager::evictTexture being a function call that itself only conditionally traces.

Yes, the conditional trace in evictTexture() is less than ideal. I kept the evictTexture() function as I'd like to distinguish between a texture being removed normally and from eviction but I instead made the function a simple wrapper around removeTexture().
Comment 5 WebKit Review Bot 2012-02-17 14:31:29 PST
Comment on attachment 127624 [details]
Patch

Clearing flags on attachment: 127624

Committed r108124: <http://trac.webkit.org/changeset/108124>
Comment 6 WebKit Review Bot 2012-02-17 14:31:33 PST
All reviewed patches have been landed.  Closing bug.