WebDatabase.closeDatabaseImmediately can crash and currently leaves affected database instanced in an odd state where transaction() calls never complete. Fixing this is part of http://code.google.com/p/chromium/issues/detail?id=98939
Here's the chromium side CL waiting on this patch. https://chromiumcodereview.appspot.com/9371008/
Created attachment 127443 [details] nuke
Comment on attachment 127443 [details] nuke View in context: https://bugs.webkit.org/attachment.cgi?id=127443&action=review > Source/WebCore/storage/Database.cpp:289 > + scriptExecutionContext()->postTask(createCallbackTask(&callTransactionErrorCallback, errorCallback, error)); error.release() > Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp:239 > + // First we have to confirm the 'database' is still in our colleciton. colleciton sp
Created attachment 127454 [details] nuke made both changes and added additional comment in the change log about a ref cycle that no longer gets created
Comment on attachment 127454 [details] nuke Rejecting attachment 127454 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp patching file Source/Webkit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/Webkit/chromium/src/WebDatabase.cpp Hunk #1 FAILED at 122. 1 out of 1 hunk FAILED -- saving rejects to file Source/Webkit/chromium/src/WebDatabase.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Levin']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11542164
Committed r108015: <http://trac.webkit.org/changeset/108015>