Bug 78837 - [chromium] Cleanup unused WebDragData methods after r107846
Summary: [chromium] Cleanup unused WebDragData methods after r107846
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 13:48 PST by Daniel Cheng
Modified: 2012-02-22 14:52 PST (History)
2 users (show)

See Also:


Attachments
Patch (10.76 KB, patch)
2012-02-16 13:53 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
EWS run? (10.79 KB, patch)
2012-02-17 11:59 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Fix layout test and crbug.com/115015 (11.21 KB, patch)
2012-02-21 14:06 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (7.65 KB, patch)
2012-02-21 17:10 PST, Daniel Cheng
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-02-16 13:48:59 PST
[chromium] Cleanup unused WebDragData methods after r107846
Comment 1 Daniel Cheng 2012-02-16 13:53:11 PST
Created attachment 127435 [details]
Patch
Comment 2 Daniel Cheng 2012-02-16 13:54:03 PST
This is a followup to r107846. Once the Source/WebKit/chromium/DEPS is rolled, I will land this patch.
Comment 3 Daniel Cheng 2012-02-17 11:59:24 PST
Created attachment 127627 [details]
EWS run?
Comment 4 WebKit Review Bot 2012-02-17 17:04:44 PST
Comment on attachment 127627 [details]
EWS run?

Attachment 127627 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11539636

New failing tests:
fast/events/drag-image-filename.html
Comment 5 Daniel Cheng 2012-02-17 17:12:50 PST
Argh. This layout test exercises a code path that's never used in the actual browser, but is tickled by DRT. I'm going to have to think of a good way to fix this...
Comment 6 Daniel Cheng 2012-02-21 14:06:22 PST
Created attachment 128039 [details]
Fix layout test and crbug.com/115015
Comment 7 Daniel Cheng 2012-02-21 17:10:07 PST
Created attachment 128087 [details]
Patch
Comment 8 Tony Chang 2012-02-22 09:52:49 PST
Comment on attachment 128087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128087&action=review

> Source/WebKit/chromium/src/WebDragData.cpp:135
> +    ensureMutable();

What is this for?  Can you mention it in the ChangeLog?
Comment 9 Daniel Cheng 2012-02-22 14:52:11 PST
Committed r108554: <http://trac.webkit.org/changeset/108554>