Bug 78824 - [Qt][WK2] Allow partial updates
Summary: [Qt][WK2] Allow partial updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2012-02-16 09:09 PST by Noam Rosenthal
Modified: 2012-02-17 03:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.87 KB, patch)
2012-02-16 23:57 PST, Noam Rosenthal
hausmann: review+
Details | Formatted Diff | Diff
Patch (9.87 KB, patch)
2012-02-17 02:02 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-02-16 09:09:44 PST
Currently our updates include complete tiles, even when only a small part of the tile is updated. this creates unnecessary large uploads.
Since the original reason to do things this way is gone, we should only create buffers when we need them.
Comment 1 Noam Rosenthal 2012-02-16 23:57:28 PST
Created attachment 127538 [details]
Patch
Comment 2 Simon Hausmann 2012-02-17 00:03:12 PST
Comment on attachment 127538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127538&action=review

Good morning ;)

> Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510
> +    ASSERT(!updateInfo.updateRects.isEmpty());

Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway?
Comment 3 Noam Rosenthal 2012-02-17 01:00:56 PST
> > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510
> > +    ASSERT(!updateInfo.updateRects.isEmpty());
> 
> Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway?

Sure, why not.
Comment 4 Simon Hausmann 2012-02-17 01:39:10 PST
Comment on attachment 127538 [details]
Patch

r=me with the ASSERT suggestion :)
Comment 5 Noam Rosenthal 2012-02-17 02:02:53 PST
Created attachment 127552 [details]
Patch
Comment 6 WebKit Review Bot 2012-02-17 03:09:24 PST
Comment on attachment 127552 [details]
Patch

Clearing flags on attachment: 127552

Committed r108055: <http://trac.webkit.org/changeset/108055>
Comment 7 WebKit Review Bot 2012-02-17 03:09:28 PST
All reviewed patches have been landed.  Closing bug.