Currently our updates include complete tiles, even when only a small part of the tile is updated. this creates unnecessary large uploads. Since the original reason to do things this way is gone, we should only create buffers when we need them.
Created attachment 127538 [details] Patch
Comment on attachment 127538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127538&action=review Good morning ;) > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510 > + ASSERT(!updateInfo.updateRects.isEmpty()); Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway?
> > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510 > > + ASSERT(!updateInfo.updateRects.isEmpty()); > > Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway? Sure, why not.
Comment on attachment 127538 [details] Patch r=me with the ASSERT suggestion :)
Created attachment 127552 [details] Patch
Comment on attachment 127552 [details] Patch Clearing flags on attachment: 127552 Committed r108055: <http://trac.webkit.org/changeset/108055>
All reviewed patches have been landed. Closing bug.