Bug 78822 - [Texmap] Improve the way we deal with BGRA extension
Summary: [Texmap] Improve the way we deal with BGRA extension
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2012-02-16 08:26 PST by Noam Rosenthal
Modified: 2012-02-16 09:48 PST (History)
2 users (show)

See Also:

Patch (14.22 KB, patch)
2012-02-16 08:31 PST, Noam Rosenthal
kenneth: review+
Details | Formatted Diff | Diff
Patch (13.53 KB, patch)
2012-02-16 09:00 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-02-16 08:26:48 PST
Right now we swizzle RGB in the web process; This doesn't take onto account GL drivers that do support BGRA (all desktop drivers, for example).
Since we're going to move to an architecture where textures are uploaded in the web-process, for now we move the swizzling back to TextureMapperGL, and do it only in the case where the extension doesn't exist.
Comment 1 Noam Rosenthal 2012-02-16 08:31:55 PST
Created attachment 127384 [details]
Comment 2 Kenneth Rohde Christiansen 2012-02-16 08:38:36 PST
Comment on attachment 127384 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=127384&action=review

r=me but please fix the minor issues

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:638
> +    return (availableExtensions.contains(extension));

why the extra ()s?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:640
> +static bool hasBgraExtension()

BGRA* this is webkit style not Qt :-)
Comment 3 Noam Rosenthal 2012-02-16 09:00:57 PST
Created attachment 127390 [details]
Comment 4 WebKit Review Bot 2012-02-16 09:48:21 PST
Comment on attachment 127390 [details]

Clearing flags on attachment: 127390

Committed r107951: <http://trac.webkit.org/changeset/107951>
Comment 5 WebKit Review Bot 2012-02-16 09:48:26 PST
All reviewed patches have been landed.  Closing bug.