Bug 7882 - Remove more DeprecatedString usage
Summary: Remove more DeprecatedString usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-20 17:08 PST by Eric Seidel (no email)
Modified: 2006-03-22 15:35 PST (History)
0 users

See Also:


Attachments
Remove more DeprecatedString (65.17 KB, patch)
2006-03-20 17:10 PST, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff
Same patch as above, ignoring whitespace (19.61 KB, patch)
2006-03-20 17:10 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-03-20 17:08:53 PST
Remove more DeprecatedString usage.... it's existance bothers me greatly ;)
Comment 1 Eric Seidel (no email) 2006-03-20 17:09:35 PST
its even.
Comment 2 Eric Seidel (no email) 2006-03-20 17:10:00 PST
Created attachment 7201 [details]
Remove more DeprecatedString
Comment 3 Eric Seidel (no email) 2006-03-20 17:10:45 PST
Created attachment 7202 [details]
Same patch as above, ignoring whitespace
Comment 4 Darin Adler 2006-03-22 08:07:59 PST
Comment on attachment 7201 [details]
Remove more DeprecatedString

-    kdDebug( 6080 ) << "CSSParser::CSSParser this=" << this << endl;
+    kdDebug(6080) << "CSSParser::CSSParser this=" << this << endl;

-    kdDebug( 6080 ) << "CSS parse error " << str << endl;
+    kdDebug(6080) << "CSS parse error " << str << endl;

We don't even have kdDebug in our tree, so this should be removed rather than reformatted.

There's a ton in this patch that has nothing to do with DeprecatedString.

-            valid_primitive = ( validUnit( value, FLength, strict ) );
+            valid_primitive = (validUnit(value, FLength, strict));

I suggest removing the parentheses altogether here.

+            // qDebug(" new value: id=%d", id);

-//     kdDebug( 6080 ) << "  got style, variant and weight current=" << valueList->currentValue << endl;
+//     kdDebug(6080) << "  got style, variant and weight current=" << valueList->currentValue << endl;

-    // kdDebug( 6080 ) << "  got size" << endl;
+    // kdDebug(6080) << "  got size" << endl;

+        //qDebug("value = %s, converted=%.2f", DeprecatedString((QChar *)t, length).latin1(), yylval->val);

Lets remove commented-out debugging code too.