Bug 78813 - Web Inspector: remove free flow DOM editing experiment.
Summary: Web Inspector: remove free flow DOM editing experiment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 07:42 PST by Pavel Feldman
Modified: 2012-02-17 00:43 PST (History)
12 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2012-02-16 07:44 PST, Pavel Feldman 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-16 07:42:38 PST 
Patch to follow.
Comment 1 Pavel Feldman 2012-02-16 07:44:58 PST 
Created attachment 127376 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-16 08:31:33 PST 
Comment on attachment 127376 [details]
Patch

Attachment 127376 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11538148

New failing tests:
inspector/elements/set-html-via-resource.html
Comment 3 Pavel Feldman 2012-02-16 08:38:14 PST 
Committed r107940: <http://trac.webkit.org/changeset/107940>
Comment 4 Timothy Hatcher 2012-02-16 12:20:10 PST 
Comment on attachment 127376 [details]
Patch

Why?
Comment 5 Pavel Feldman 2012-02-17 00:43:30 PST 
(In reply to comment #4)
> (From update of attachment 127376 [details])
> Why?

Experiment was allowing free flow HTML editing from resources panel and was patching the DOM. It was also creating revisions of HTML document upon edits in the Elements panel.

While it was working intuitively and well for static pages, I was struggling to make it work for highly dynamic pages (like inspector.html). Since it was editing DOM, not HTML, it was mixing the concepts and was suggesting that serialized DOM was a revision of the resource. The diff for such a revision was huge and non-helpful.

I was also trying to toggle between ElementsTreeOutline and TextEditor in the ElementsPanel, so that free flow DOM editign took place where expected, but it needed tabbed interface (due to multiple iframes) and switching between the DOM and editors was non-intuitive (keeping them in sync was challenging).