Bug 78811 - [Qt] Fix linking in debug builds on Mac OS X
Summary: [Qt] Fix linking in debug builds on Mac OS X
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 07:14 PST by Alexander Færøy
Modified: 2012-02-16 09:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2012-02-16 07:15 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2012-02-16 08:44 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-02-16 07:14:06 PST 
SSIA.
Comment 1 Alexander Færøy 2012-02-16 07:15:54 PST 
Created attachment 127374 [details]
Patch
Comment 2 Alexander Færøy 2012-02-16 07:17:00 PST 
Adding Tor Arne for review.
Comment 3 Alexander Færøy 2012-02-16 07:27:48 PST 
Adding Kenneth as he just came by :-)
Comment 4 Kenneth Rohde Christiansen 2012-02-16 08:10:17 PST 
Comment on attachment 127374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127374&action=review

> Source/WebKit2/UIProcess/API/qt/tests/bytearraytestdata.h:36
> +    virtual ~ByteArrayTestData();

why not just implement it here?
Comment 5 Alexander Færøy 2012-02-16 08:44:01 PST 
Created attachment 127387 [details]
Patch
Comment 6 WebKit Review Bot 2012-02-16 09:31:52 PST 
The commit-queue encountered the following flaky tests while processing attachment 127387 [details]:

perf/array-reverse.html bug 78593 (author: ojan@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2012-02-16 09:33:56 PST 
Comment on attachment 127387 [details]
Patch

Clearing flags on attachment: 127387

Committed r107949: <http://trac.webkit.org/changeset/107949>
Comment 8 WebKit Review Bot 2012-02-16 09:34:01 PST 
All reviewed patches have been landed.  Closing bug.