Bug 78797 - add kraken 1.1 to PerformanceTests/SunSpider
Summary: add kraken 1.1 to PerformanceTests/SunSpider
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Wingo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 03:25 PST by Andy Wingo
Modified: 2012-02-20 03:04 PST (History)
5 users (show)

See Also:


Attachments
patch to add kraken tests (deleted)
2012-02-20 03:04 PST, Andy Wingo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2012-02-16 03:25:11 PST
The patch to be attached adds the kraken 1.1 tests to our SunSpider harness, for convenience.
Comment 1 Andy Wingo 2012-02-16 03:33:05 PST
Adding JSC folks for review/comment.
Comment 2 Andy Wingo 2012-02-16 03:37:18 PST
The patch failed to attach, presumably because it was 9 MB.  It's a lot of data, but kraken is a useful and common test, so perhaps it is worth it to have a copy in the WebKit repo.  Comments?

Here's the diffstat:

 PerformanceTests/SunSpider/ChangeLog                                             |   37 +
 PerformanceTests/SunSpider/tests/kraken-1.1/LIST                                 |   14 +
 PerformanceTests/SunSpider/tests/kraken-1.1/ai-astar-data.js                     |50256 ++++++++++++++++++++++++++++++
 PerformanceTests/SunSpider/tests/kraken-1.1/ai-astar.js                          |  150 +
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-beat-detection-data.js         | 2581 ++
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-beat-detection.js              |   19 +
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-dft-data.js                    | 1918 ++
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-dft.js                         |   10 +
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-fft-data.js                    | 1921 ++
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-fft.js                         |   12 +
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-oscillator-data.js             | 1918 ++
 PerformanceTests/SunSpider/tests/kraken-1.1/audio-oscillator.js                  |   16 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-darkroom-data.js             |  114 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-darkroom.js                  |    5 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-desaturate-data.js           |    3 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-desaturate.js                |   40 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-gaussian-blur-data.js        |   38 +
 PerformanceTests/SunSpider/tests/kraken-1.1/imaging-gaussian-blur.js             |   25 +
 PerformanceTests/SunSpider/tests/kraken-1.1/json-parse-financial-data.js         |  103 +
 PerformanceTests/SunSpider/tests/kraken-1.1/json-parse-financial.js              |    4 +
 PerformanceTests/SunSpider/tests/kraken-1.1/json-stringify-tinderbox-data.js     |  132 +
 PerformanceTests/SunSpider/tests/kraken-1.1/json-stringify-tinderbox.js          |    4 +
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-aes-data.js          | 6458 ++++
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-aes.js               |   23 +
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-ccm-data.js          | 7227 +++++
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-ccm.js               |   33 +
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-pbkdf2-data.js       |  222 +
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-pbkdf2.js            |   20 +
 .../SunSpider/tests/kraken-1.1/stanford-crypto-sha256-iterative-data.js          |  223 +
 PerformanceTests/SunSpider/tests/kraken-1.1/stanford-crypto-sha256-iterative.js  |   36 +
 30 files changed, 73562 insertions(+), 0 deletions(-)
Comment 3 Gavin Barraclough 2012-02-16 14:49:09 PST
Last I looked, the kraken licensing terms seemed unclear, and many of the tests contained statements asserting copyright without obvious associated open source licensing terms.  Is this a little more transparent now? – are these tests clearly under a license we use?

If so, it would be very convenient to have a copy of thee in our tree.

There is a checkbox for 'big file' on the attachments page – did you try that? (can't say I've used it myself to know if it works :-) ).
Comment 4 Andy Wingo 2012-02-20 03:04:16 PST
Created attachment 127795 [details]
patch to add kraken tests

Here's the patch, now that I'm manually attaching it.  I had gotten too used to webkit-patch upload ;-)

Please note that the license muddiness that Gavin notes in comment 3 are still present.  I looked into the hg repo and things are not clear at all.  I will send a message to Rob Sayre and see if he can clear it up.