Bug 78781 – MediaStream API: Need to support MediaStream constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[William Lin]

Although there is an implementation of MediaStream constructor, web app developer can't call JavaScript api to new a MediaStream

[William Lin]

Created attachment 127317 [details]
UseCase

1. click 'add webcam' button to get local MediaStream
2. click 'duplicate mediaStream' button to construct a new MediaStream

[William Lin]

Created attachment 127319 [details]
P

[Tommy Widenflycht]

Thanks for fixing!

[Adam Barth]

Comment on attachment 127319 [details]
P

If you'd like this patch incorporated into trunk, please see these instructions: http://www.webkit.org/coding/contributing.html

In particular, you need to mark the patch review? and include a test that exercises your change.

[Adam Barth]

Comment on attachment 127319 [details]
P

View in context: https://bugs.webkit.org/attachment.cgi?id=127319&action=review

> Source/WebCore/ChangeLog:3
> +        Fix bug from r107672.

This line should also match the title of the bug.

[Jeremy Mao]

Created attachment 132557 [details]
Patch

[Adam Barth]

This isn't specific to JSC.

[Adam Barth]

Comment on attachment 132557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132557&action=review

Ok.  Ideally we'd have a test that exercises the constructor.

> Source/WebCore/ChangeLog:8
> +        No new tests.

Does this make some of the existing tests pass?

[Tommy Widenflycht]

Just FYI: Creating a MediaStram out of tracks from other MediaStreams isn't tested in Chromium yet.

[Jeremy Mao]

(In reply to comment #7)
> This isn't specific to JSC.
Yes, it's not specific to JSC, thanks for changing the title.

[Jeremy Mao]

(In reply to comment #8)
> (From update of attachment 132557 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132557&action=review
> Ok.  Ideally we'd have a test that exercises the constructor.
> > Source/WebCore/ChangeLog:8
> > +        No new tests.
> Does this make some of the existing tests pass?
Currently in Webkit there's no tests exercise this media stream constructor, because creating a new media stream need a exsiting media steam which we cannot get from getUserMedia. getUserMedia now has a impelementation only for the chromium port, I have tested this use case on chromium, it works.

[WebKit Review Bot]

Comment on attachment 132557 [details]
Patch

Clearing flags on attachment: 132557

Committed r111558: <http://trac.webkit.org/changeset/111558>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.