Bug 78780 - Web Inspector: move style disable checkboxes to the left
Summary: Web Inspector: move style disable checkboxes to the left
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
: 37770 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-15 22:46 PST by Pavel Feldman
Modified: 2012-02-17 03:44 PST (History)
11 users (show)

See Also:


Attachments
[IMAGE] Screenshot with patch applied. (61.94 KB, image/png)
2012-02-15 22:46 PST, Pavel Feldman
no flags Details
[IMAGE] Looks with patch applied. (72.03 KB, image/png)
2012-02-16 05:45 PST, Pavel Feldman
no flags Details
Patch (9.75 KB, patch)
2012-02-16 05:47 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (9.05 KB, patch)
2012-02-16 06:13 PST, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-15 22:46:05 PST
Screenshot to follow.
Comment 1 Pavel Feldman 2012-02-15 22:46:28 PST
Created attachment 127313 [details]
[IMAGE] Screenshot with patch applied.
Comment 2 Pavel Feldman 2012-02-16 05:45:21 PST
Created attachment 127362 [details]
[IMAGE] Looks with patch applied.
Comment 3 Pavel Feldman 2012-02-16 05:47:12 PST
Created attachment 127363 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-02-16 06:09:55 PST
Comment on attachment 127363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review

Please add some space between checkbox and style.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770
> -        if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root)

Isn't that breaking computed style? r- for that.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935
> -        this.hasChildren = false;

Please keep lying.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092
> -        this.hasChildren = context.hasChildren;

ditto.
Comment 5 Pavel Feldman 2012-02-16 06:12:37 PST
(In reply to comment #4)
> (From update of attachment 127363 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review
> 
> Please add some space between checkbox and style.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770
> > -        if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root)
> 
> Isn't that breaking computed style? r- for that.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935
> > -        this.hasChildren = false;
> 
> Please keep lying.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092
> > -        this.hasChildren = context.hasChildren;
> 
> ditto.

Done.
Comment 6 Pavel Feldman 2012-02-16 06:13:14 PST
Created attachment 127368 [details]
Patch
Comment 7 Alexander Pavlov (apavlov) 2012-02-16 06:23:58 PST
Comment on attachment 127368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127368&action=review

> Source/WebCore/inspector/front-end/elementsPanel.css:398
> +    opacity: 0;

visibility: hidden; seems more appropriate in this case

> Source/WebCore/inspector/front-end/treeoutline.js:867
>      else if (element.treeElement.hasChildren && !element.treeElement.expanded)

Should go on the previous line, after '}'
Comment 8 Pavel Feldman 2012-02-16 07:34:35 PST
Committed r107933: <http://trac.webkit.org/changeset/107933>
Comment 9 Alexander Pavlov (apavlov) 2012-02-17 03:44:20 PST
*** Bug 37770 has been marked as a duplicate of this bug. ***