Bug 78780 – Web Inspector: move style disable checkboxes to the left

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Screenshot to follow.

[Pavel Feldman]

Created attachment 127313 [details]
[IMAGE] Screenshot with patch applied.

[Pavel Feldman]

Created attachment 127362 [details]
[IMAGE] Looks with patch applied.

[Pavel Feldman]

Created attachment 127363 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 127363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review

Please add some space between checkbox and style.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770
> -        if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root)

Isn't that breaking computed style? r- for that.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935
> -        this.hasChildren = false;

Please keep lying.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092
> -        this.hasChildren = context.hasChildren;

ditto.

[Pavel Feldman]

(In reply to comment #4)
> (From update of attachment 127363 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review
> 
> Please add some space between checkbox and style.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770
> > -        if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root)
> 
> Isn't that breaking computed style? r- for that.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935
> > -        this.hasChildren = false;
> 
> Please keep lying.
> 

Done.

> > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092
> > -        this.hasChildren = context.hasChildren;
> 
> ditto.

Done.

[Pavel Feldman]

Created attachment 127368 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 127368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127368&action=review

> Source/WebCore/inspector/front-end/elementsPanel.css:398
> +    opacity: 0;

visibility: hidden; seems more appropriate in this case

> Source/WebCore/inspector/front-end/treeoutline.js:867
>      else if (element.treeElement.hasChildren && !element.treeElement.expanded)

Should go on the previous line, after '}'

[Pavel Feldman]

Committed r107933: <http://trac.webkit.org/changeset/107933>

[Alexander Pavlov (apavlov)]

*** Bug 37770 has been marked as a duplicate of this bug. ***