Bug 78777 – Numerous trivial bugs in Object.defineProperty

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

There are a handful of really trivial bugs, related to Object.defineProperty:
    * Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
    * Calling an undefined setter should only throw in strict mode.
    * When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
    * Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
    * Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
    * If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
    * 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
    * Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
    * Should be able to define an non-configurable accessor.
These are mostly all one-line changes, inverted boolean checks, masking against wrong attribute, etc.

Fixing these would resolve about 80% of our outstanding test-262 failures.

[Gavin Barraclough]

Created attachment 127309 [details]
Fix

[Gavin Barraclough]

Created attachment 127310 [details]
With fixed Changelog

[WebKit Review Bot]

Comment on attachment 127310 [details]
With fixed Changelog

Attachment 127310 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11536144

New failing tests:
fast/js/property-getters-and-setters.html

[Gavin Barraclough]

Fixed in r107956