Bug 78774 - Fix the broken viewport tests
Summary: Fix the broken viewport tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 68044
  Show dependency treegraph
 
Reported: 2012-02-15 19:34 PST by Mark Hahnenberg
Modified: 2012-02-16 16:54 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.40 KB, patch)
2012-02-15 19:44 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (9.01 KB, patch)
2012-02-15 21:17 PST, Mark Hahnenberg
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-02-15 19:34:58 PST
The patch for bug 68044 broke a few tests in fast/viewport. We should fix these for the platforms that support them.
Comment 1 Mark Hahnenberg 2012-02-15 19:44:25 PST
Created attachment 127298 [details]
Patch
Comment 2 Mark Hahnenberg 2012-02-15 21:17:41 PST
Created attachment 127308 [details]
Patch
Comment 3 Kenneth Rohde Christiansen 2012-02-16 02:07:53 PST
Comment on attachment 127308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127308&action=review

> Source/JavaScriptCore/wtf/text/WTFString.h:90
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);

Maybe charactersToFloatIgnoringJunk would be more descriptive?

> Source/JavaScriptCore/wtf/text/WTFString.h:92
>  WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);

Btw, does the didReadNumber make sense for the non-junk versions?
Comment 4 Mark Hahnenberg 2012-02-16 10:21:10 PST
> Btw, does the didReadNumber make sense for the non-junk versions?
I think it still does in case somebody wants to do some additional parsing based on whether or not the prefix of the string is a number of some sort.
Comment 5 Mark Hahnenberg 2012-02-16 16:54:50 PST
Committed r108001: <http://trac.webkit.org/changeset/108001>