The patch for bug 68044 broke a few tests in fast/viewport. We should fix these for the platforms that support them.
Created attachment 127298 [details] Patch
Created attachment 127308 [details] Patch
Comment on attachment 127308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127308&action=review > Source/JavaScriptCore/wtf/text/WTFString.h:90 > +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); Maybe charactersToFloatIgnoringJunk would be more descriptive? > Source/JavaScriptCore/wtf/text/WTFString.h:92 > WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); > +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); Btw, does the didReadNumber make sense for the non-junk versions?
> Btw, does the didReadNumber make sense for the non-junk versions? I think it still does in case somebody wants to do some additional parsing based on whether or not the prefix of the string is a number of some sort.
Committed r108001: <http://trac.webkit.org/changeset/108001>