Bug 78770 - [BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
Summary: [BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-02-15 18:36 PST by Leo Yang
Modified: 2012-02-15 19:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.05 KB, patch)
2012-02-15 18:49 PST, Leo Yang 		rwlbuis: review+
Details | Formatted Diff | Diff
Patch v2 (5.08 KB, patch)
2012-02-15 19:07 PST, Leo Yang 		rwlbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-02-15 18:36:12 PST 
WebKit/blackberry/Api/WebPageGroupLoadDeferrer.{h, cpp} are implementing a wrapper of WebCore::PageGroupLoadDeferrer.
Comment 1 Leo Yang 2012-02-15 18:49:54 PST 
Created attachment 127293 [details]
Patch
Comment 2 Rob Buis 2012-02-15 18:59:20 PST 
Comment on attachment 127293 [details]
Patch

LGTM.
Comment 3 Antonio Gomes 2012-02-15 18:59:56 PST 
Comment on attachment 127293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review

> Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32
> +    m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true);

lets add a /*whatIsThisBool*/-like comment.
Comment 4 Leo Yang 2012-02-15 19:01:14 PST 
(In reply to comment #3)
> (From update of attachment 127293 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review
> 
> > Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32
> > +    m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true);
> 
> lets add a /*whatIsThisBool*/-like comment.

ok. thanks.
Comment 5 Leo Yang 2012-02-15 19:07:06 PST 
Created attachment 127296 [details]
Patch v2
Comment 6 Rob Buis 2012-02-15 19:08:52 PST 
Comment on attachment 127296 [details]
Patch v2

Antonio made a good point, I guess an enum instead of a bool would have helped there. Looks good!
Comment 7 Leo Yang 2012-02-15 19:28:19 PST 
Committed r107873: <http://trac.webkit.org/changeset/107873>