RESOLVED FIXED 78770
[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp} 
https://bugs.webkit.org/show_bug.cgi?id=78770
Summary [BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
Leo Yang
Reported 2012-02-15 18:36:12 PST
WebKit/blackberry/Api/WebPageGroupLoadDeferrer.{h, cpp} are implementing a wrapper of WebCore::PageGroupLoadDeferrer.
Attachments
Patch (5.05 KB, patch)
2012-02-15 18:49 PST, Leo Yang 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch v2 (5.08 KB, patch)
2012-02-15 19:07 PST, Leo Yang 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-02-15 18:49:54 PST
Created attachment 127293 [details] Patch
Rob Buis
Comment 2 2012-02-15 18:59:20 PST
Comment on attachment 127293 [details] Patch LGTM.
Antonio Gomes
Comment 3 2012-02-15 18:59:56 PST
Comment on attachment 127293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review > Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32 > + m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true); lets add a /*whatIsThisBool*/-like comment.
Leo Yang
Comment 4 2012-02-15 19:01:14 PST
(In reply to comment #3) > (From update of attachment 127293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review > > > Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32 > > + m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true); > > lets add a /*whatIsThisBool*/-like comment. ok. thanks.
Leo Yang
Comment 5 2012-02-15 19:07:06 PST
Created attachment 127296 [details] Patch v2
Rob Buis
Comment 6 2012-02-15 19:08:52 PST
Comment on attachment 127296 [details] Patch v2 Antonio made a good point, I guess an enum instead of a bool would have helped there. Looks good!
Leo Yang
Comment 7 2012-02-15 19:28:19 PST
Committed r107873: <http://trac.webkit.org/changeset/107873>
Note You need to log in before you can comment on or make changes to this bug.