Bug 78767 – REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Brady Eidson]

REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages

The subtle change to "isLoadingInAPISense" did in fact break at least one real world app.

An app-specific quirk patch is coming soon.

[Brady Eidson]

Created attachment 127286 [details]
Patch v1 - New setting and app-specific quirk

[Sam Weinig]

Comment on attachment 127286 [details]
Patch v1 - New setting and app-specific quirk

View in context: https://bugs.webkit.org/attachment.cgi?id=127286&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
> +          and there are outstanding subresource loads.

Odd spacing here.

> Source/WebCore/loader/DocumentLoader.cpp:452
> +        if (m_frame->settings()->needsIsLoadingInAPISenseQuirk() && !m_subresourceLoaders.isEmpty())
> +            return true;

Why is this not using a check from RuntimeApplicationChecks.h?

> Source/WebCore/page/Settings.h:530
> +        void setNeedsIsLoadingInAPISenseQuirk(bool enabled) { m_needsIsLoadingInAPISenseQuirk = enabled; }
> +        bool needsIsLoadingInAPISenseQuirk() const { return m_needsIsLoadingInAPISenseQuirk; }

Please add a comment indicating what this quirk is.

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 127286 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127286&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        (WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
> > +          and there are outstanding subresource loads.
> 
> Odd spacing here.
> 
> > Source/WebCore/loader/DocumentLoader.cpp:452
> > +        if (m_frame->settings()->needsIsLoadingInAPISenseQuirk() && !m_subresourceLoaders.isEmpty())
> > +            return true;
> 
> Why is this not using a check from RuntimeApplicationChecks.h?

We've never done version checks from WebCore before.  While it's technically possible, I opted to stick with the pattern we've historically used to do version checks in WebKit/Mac.

> 
> > Source/WebCore/page/Settings.h:530
> > +        void setNeedsIsLoadingInAPISenseQuirk(bool enabled) { m_needsIsLoadingInAPISenseQuirk = enabled; }
> > +        bool needsIsLoadingInAPISenseQuirk() const { return m_needsIsLoadingInAPISenseQuirk; }
> 
> Please add a comment indicating what this quirk is.

Gotcha.

Thanks!

[Alexey Proskuryakov]

Looks like this was committed in <http://trac.webkit.org/changeset/107995>.