Bug 78765 - ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
Summary: ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-15 17:30 PST by Matthew Delaney
Modified: 2012-02-16 17:40 PST (History)
2 users (show)

See Also:


Attachments
Patch (9.83 KB, patch)
2012-02-16 16:49 PST, Matthew Delaney
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2012-02-15 17:30:49 PST
Sometimes shadows draw via ShadowBlur.cpp are corrupted, containing contents of old shadows. The checks in matchesLastShadow() don't consider when m_layerSize changes and thus some of the old content of the scratch buffer might be drawn. This patch is to store the last m_layerSize value and make sure that matches as well.
Comment 1 Matthew Delaney 2012-02-15 17:31:18 PST
<rdar://problem/10670507>
Comment 2 Matthew Delaney 2012-02-16 16:49:31 PST
Created attachment 127467 [details]
Patch
Comment 3 Matthew Delaney 2012-02-16 17:40:39 PST
Committed r108008: <http://trac.webkit.org/changeset/108008>