WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78764
ENH: Add ability to run subset of JavaScript layout tests with JSC
https://bugs.webkit.org/show_bug.cgi?id=78764
Summary
ENH: Add ability to run subset of JavaScript layout tests with JSC
Michael Saboff
Reported
2012-02-15 17:28:46 PST
There are many JavaScript tests that don't need a browser or DumpRenderTree to test. Most of fast/js and fast/regex fall into this category. We should add a method to run these tests using the jsc command.
Attachments
Proposed patch
(16.80 KB, patch)
2012-02-15 17:41 PST
,
Michael Saboff
barraclough
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2012-02-15 17:41:20 PST
Created
attachment 127284
[details]
Proposed patch
Alexey Proskuryakov
Comment 2
2012-02-15 22:56:34 PST
Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly? I'm fairly sure that this used to be the idea.
Michael Saboff
Comment 3
2012-02-16 16:46:56 PST
Committed
r107997
: <
http://trac.webkit.org/changeset/107997
>
Michael Saboff
Comment 4
2012-02-17 11:46:53 PST
(In reply to
comment #2
)
> Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly? > > I'm fairly sure that this used to be the idea.
I think that is achievable. The list of tests in the patch was derived by running all js tests from the command line and excluding those that failed. Some of those failures were due to markup present in output causing mismatch. That is easily fixed. Other tests require or currently use the DOM and these might be harder to coerce to running under jsc. Asynchronous tests would require more changes or might not work at all. Then there are the 20 regex tests. They could be moved to fast/js. Before moving things around, I think it makes sense to see how many of the tests that fail under jsc could be easily made to pass. After that I suspect that we'd have a small list to move. It still makes sense to pass the driver a list as one may want to only run a subset of tests.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug