Bug 78764 - ENH: Add ability to run subset of JavaScript layout tests with JSC
Summary: ENH: Add ability to run subset of JavaScript layout tests with JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-15 17:28 PST by Michael Saboff
Modified: 2012-02-17 11:46 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (16.80 KB, patch)
2012-02-15 17:41 PST, Michael Saboff
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-02-15 17:28:46 PST
There are many JavaScript tests that don't need a browser or DumpRenderTree to test.  Most of fast/js and fast/regex fall into this category.  We should add a method to run these tests using the jsc command.
Comment 1 Michael Saboff 2012-02-15 17:41:20 PST
Created attachment 127284 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2012-02-15 22:56:34 PST
Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly?

I'm fairly sure that this used to be the idea.
Comment 3 Michael Saboff 2012-02-16 16:46:56 PST
Committed r107997: <http://trac.webkit.org/changeset/107997>
Comment 4 Michael Saboff 2012-02-17 11:46:53 PST
(In reply to comment #2)
> Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly?
> 
> I'm fairly sure that this used to be the idea.

I think that is achievable.  The list of tests in the patch was derived by running all js tests from the command line and excluding those that failed.  Some of those failures were due to markup present in output causing mismatch.  That is easily fixed. Other tests require or currently use the DOM and these might be harder to coerce to running under jsc. Asynchronous tests would require more changes or might not work at all.

Then there are the 20 regex tests.  They could be moved to fast/js.

Before moving things around, I think it makes sense to see how many of the tests that fail under jsc could be easily made to pass.  After that I suspect that we'd have a small list to move.  It still makes sense to pass the driver a list as one may want to only run a subset of tests.