Bug 78761 - [CSSRegions]overflowRegion tests are flaky
Summary: [CSSRegions]overflowRegion tests are flaky
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 66643
  Show dependency treegraph
Reported: 2012-02-15 16:42 PST by Tony Chang
Modified: 2012-02-16 11:40 PST (History)
4 users (show)

See Also:

patch (7.61 KB, patch)
2012-02-16 07:07 PST, Raul Hudea
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-02-15 16:42:15 PST
In http://trac.webkit.org/changeset/107827, I tried to make the webkitOverflowRegion tests non flaky.  The problem is that we're getting a layout before the script runs.  My attempts failed-- the tests still sometimes fail on debug builds on chromium:

It seems weird that this DOM property depends on internal details of whether we've run layout or not.  It seems like it should force a layout when the property is accessed.

The current tests seem incorrect in that the first time we read webkitOverflowRegion we expect undefined.  At that point in time, we should probably get back 'empty'.  'undefined' means that the element is not a region, but it is.
Comment 1 Raul Hudea 2012-02-16 03:38:17 PST
You're right. Reading the webkitOverflowRegion property should trigger a layout. I'll make a fix for this
Comment 2 Raul Hudea 2012-02-16 07:07:30 PST
Created attachment 127373 [details]
Comment 3 WebKit Review Bot 2012-02-16 11:40:11 PST
Comment on attachment 127373 [details]

Clearing flags on attachment: 127373

Committed r107961: <http://trac.webkit.org/changeset/107961>
Comment 4 WebKit Review Bot 2012-02-16 11:40:17 PST
All reviewed patches have been landed.  Closing bug.