Bug 78755 - [chromium] REGRESSION(r107836): box shadow test failures
Summary: [chromium] REGRESSION(r107836): box shadow test failures
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
Depends on: 78759 78775 78859
  Show dependency treegraph
Reported: 2012-02-15 15:43 PST by Tony Chang
Modified: 2012-02-17 15:14 PST (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-02-15 15:43:41 PST
http://trac.webkit.org/r107836 in bug 78728 was supposed to be a refactoring that improved performance.  Some tests had minor changes (I'll rebaseline those), but 3 tests failed in unexpected ways.  Those tests are:

- fast/box-shadow/spread.html : the black shapes got smaller
- fast/writing-mode/box-shadow-horizontal-bt.html : the shadow disappeared from the first line of text
- fast/writing-mode/box-shadow-vertical-lr.html : same as above, the shadow disappeared from the first line of text
Comment 1 Tony Chang 2012-02-15 15:44:00 PST
I'm going to mark the three tests as failing while I wait to hear back from mitz.
Comment 2 Tony Chang 2012-02-15 15:55:20 PST
fast/writing-mode/box-shadow-vertical-rl.html is also failing in the same way as the other two writing mode box shadow tests.
Comment 3 noel gordon 2012-02-15 21:01:04 PST
compositing/culling/scrolled-within-boxshadow.html also regressed, right?
Comment 4 noel gordon 2012-02-15 21:31:19 PST
Marked it failing in https://bugs.webkit.org/show_bug.cgi?id=78755
Comment 5 noel gordon 2012-02-15 21:44:46 PST
Ahem, marked it failing in http://trac.webkit.org/changeset/107882
Comment 6 Dana Jansens 2012-02-16 11:54:07 PST
https://bugs.webkit.org/show_bug.cgi?id=78775 appears to fix all of these. Will re-enable once it lands and they show up green in the dashboard.
Comment 7 Tony Chang 2012-02-16 12:33:39 PST
http://trac.webkit.org/changeset/107969 re-enabled the spread and box-shadow-* tests.  compositing/culling/scrolled-within-boxshadow.html is still failing.  I'll ask mitz about it.
Comment 8 noel gordon 2012-02-17 15:13:58 PST
http://trac.webkit.org/changeset/108115 re-enabled compositing/culling/scrolled-within-boxshadow.html