Bug 78747 - Add zeroLayoutUnit constant.
Summary: Add zeroLayoutUnit constant.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2012-02-15 14:47 PST by Levi Weintraub
Modified: 2012-02-15 20:49 PST (History)
5 users (show)

See Also:

Patch (39.96 KB, patch)
2012-02-15 14:59 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-02-15 14:47:49 PST
When we switch to subpixel LayoutUnits, we can't use raw integers in places like ternary operations. This patch adds a zeroLayoutUnit constant that can be used instead of raw zeros.
Comment 1 Levi Weintraub 2012-02-15 14:59:15 PST
Created attachment 127244 [details]
Comment 2 Eric Seidel (no email) 2012-02-15 15:02:56 PST
Comment on attachment 127244 [details]

OK.  Seems you added LayoutRect::zero() in another patch.  Since this is still a typedef, Ican see how that's impossible here.  Is the plan to move to something like that?  Doesn't really matter, just curious.
Comment 3 Levi Weintraub 2012-02-15 15:07:07 PST
Comment on attachment 127244 [details]

A LayoutRect would be different, but I think you meant LayoutUnit. I think it'd make sense to keep this as a constant.

Thanks for the review!
Comment 4 WebKit Review Bot 2012-02-15 20:49:22 PST
Comment on attachment 127244 [details]

Clearing flags on attachment: 127244

Committed r107880: <http://trac.webkit.org/changeset/107880>
Comment 5 WebKit Review Bot 2012-02-15 20:49:28 PST
All reviewed patches have been landed.  Closing bug.