Bug 78669 - [EFL] Check the tile's zoom factor before rendering.
Summary: [EFL] Check the tile's zoom factor before rendering.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 22:00 PST by JungJik Lee
Modified: 2012-03-28 06:34 PDT (History)
6 users (show)

See Also:


Attachments
proposal patch (1.52 KB, patch)
2012-02-14 22:34 PST, JungJik Lee
no flags Details | Formatted Diff | Diff
revised_patch_1 (1.62 KB, patch)
2012-02-15 01:04 PST, JungJik Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JungJik Lee 2012-02-14 22:00:11 PST
It needs to check the zoom factor of the tile before drawing the tile.
At the current code, the rendering function only checks the tile's width and height.
Comment 1 JungJik Lee 2012-02-14 22:34:33 PST
Created attachment 127119 [details]
proposal patch
Comment 2 Gyuyoung Kim 2012-02-14 23:13:44 PST
Comment on attachment 127119 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review

> Source/WebKit/efl/ChangeLog:9
> +        Before rendering the tile, it needs to check the zoom factor too.

I think you need to mention why zoom factor needs to be checked as well.
Comment 3 JungJik Lee 2012-02-14 23:51:44 PST
(In reply to comment #2)
> (From update of attachment 127119 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        Before rendering the tile, it needs to check the zoom factor too.
> 
> I think you need to mention why zoom factor needs to be checked as well.

After merging this patch(http://wkb.ug/68595), we manages the matrices which have each different zoom factors. So the tiles in different zoom level's matrix can be rendered.
Comment 4 Gyuyoung Kim 2012-02-15 00:36:34 PST
Comment on attachment 127119 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review

>>> Source/WebKit/efl/ChangeLog:9
>>> +        Before rendering the tile, it needs to check the zoom factor too.
>> 
>> I think you need to mention why zoom factor needs to be checked as well.
> 
> After merging this patch(http://wkb.ug/68595), we manages the matrices which have each different zoom factors. So the tiles in different zoom level's matrix can be rendered.

I mean it is better to write above reason to ChangeLog.
Comment 5 JungJik Lee 2012-02-15 01:04:47 PST
Created attachment 127129 [details]
revised_patch_1
Comment 6 Gyuyoung Kim 2012-02-15 01:17:32 PST
Comment on attachment 127129 [details]
revised_patch_1

LGTM.
Comment 7 KwangHyuk 2012-02-20 05:46:29 PST
> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:609
> +    if (priv->view.tile.zoom != tile->zoom || priv->view.tile.width != tile->width || priv->view.tile.height != tile->height)

For the patch, it might be started from assumption. so, I would like to see the test scenario or clue about issue ?
On the other hand, I suggest you to check whether you can remove "priv->view.tile.width != tile->width || priv->view.tile.height != tile->height" because there was no api to change tile size at runtime.
Comment 8 JungJik Lee 2012-03-28 06:32:59 PDT
To KwangHyuk, as you know this, it was an internal issue.
So that I made this patch but it does not occur anymore in both open source and internal project. I'll change this patch's flag to invalid. In addition, I think it is better to remove the line later with other useless code.