Bug 78667 - Stop using script-tests in LayoutTests/fast/forms
Summary: Stop using script-tests in LayoutTests/fast/forms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 65915
  Show dependency treegraph
 
Reported: 2012-02-14 21:17 PST by Kent Tamura
Modified: 2012-02-14 22:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (318.01 KB, patch)
2012-02-14 21:20 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-02-14 21:17:44 PST
Stop using script-tests in LayoutTests/fast/forms
Comment 1 Kent Tamura 2012-02-14 21:20:24 PST
Created attachment 127110 [details]
Patch
Comment 2 Kentaro Hara 2012-02-14 21:41:55 PST
Comment on attachment 127110 [details]
Patch

Just an out-of-curiosity question: What is the benefit of the change?

There had been a discussion that it might not worth making existing tests pretty for the sake of prettiness or even consistency: https://lists.webkit.org/pipermail/webkit-dev/2011-December/018948.html
Comment 3 Kent Tamura 2012-02-14 21:46:51 PST
The benefit is ease of moving these tests to other directories.
I'm working on splitting tests in fast/forms/ into several sub-directories (Bug 65915). script-tests makes it harder.
Comment 4 Kentaro Hara 2012-02-14 21:49:01 PST
Comment on attachment 127110 [details]
Patch

Makes sense! Please cq+ it after making bots happy.
Comment 5 WebKit Review Bot 2012-02-14 22:56:20 PST
Comment on attachment 127110 [details]
Patch

Clearing flags on attachment: 127110

Committed r107781: <http://trac.webkit.org/changeset/107781>
Comment 6 WebKit Review Bot 2012-02-14 22:56:25 PST
All reviewed patches have been landed.  Closing bug.