WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 78667
Stop using script-tests in LayoutTests/fast/forms
https://bugs.webkit.org/show_bug.cgi?id=78667
Summary
Stop using script-tests in LayoutTests/fast/forms
Kent Tamura
Reported
2012-02-14 21:17:44 PST
Stop using script-tests in LayoutTests/fast/forms
Attachments
Patch
(318.01 KB, patch)
2012-02-14 21:20 PST
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2012-02-14 21:20:24 PST
Created
attachment 127110
[details]
Patch
Kentaro Hara
Comment 2
2012-02-14 21:41:55 PST
Comment on
attachment 127110
[details]
Patch Just an out-of-curiosity question: What is the benefit of the change? There had been a discussion that it might not worth making existing tests pretty for the sake of prettiness or even consistency:
https://lists.webkit.org/pipermail/webkit-dev/2011-December/018948.html
Kent Tamura
Comment 3
2012-02-14 21:46:51 PST
The benefit is ease of moving these tests to other directories. I'm working on splitting tests in fast/forms/ into several sub-directories (
Bug 65915
). script-tests makes it harder.
Kentaro Hara
Comment 4
2012-02-14 21:49:01 PST
Comment on
attachment 127110
[details]
Patch Makes sense! Please cq+ it after making bots happy.
WebKit Review Bot
Comment 5
2012-02-14 22:56:20 PST
Comment on
attachment 127110
[details]
Patch Clearing flags on attachment: 127110 Committed
r107781
: <
http://trac.webkit.org/changeset/107781
>
WebKit Review Bot
Comment 6
2012-02-14 22:56:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug