Bug 78661 - Remove ScrollableArea::handleGestureEvent
Summary: Remove ScrollableArea::handleGestureEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 78666
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-14 19:28 PST by Anders Carlsson
Modified: 2012-02-15 10:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.03 KB, patch)
2012-02-14 19:30 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (6.02 KB, text/plain)
2012-02-14 21:43 PST, noel gordon 		no flags Details
Patch (9.52 KB, patch)
2012-02-15 10:36 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-14 19:28:41 PST 
Remove ScrollableArea::handleGestureEvent
Comment 1 Anders Carlsson 2012-02-14 19:30:51 PST 
Created attachment 127103 [details]
Patch
Comment 2 Anders Carlsson 2012-02-14 19:57:03 PST 
Committed r107774: <http://trac.webkit.org/changeset/107774>
Comment 3 noel gordon 2012-02-14 21:43:31 PST 
Reopening to attach new patch.
Comment 4 noel gordon 2012-02-14 21:43:35 PST 
Created attachment 127112 [details]
Patch
Comment 5 Anders Carlsson 2012-02-15 10:36:09 PST 
Created attachment 127197 [details]
Patch
Comment 6 WebKit Review Bot 2012-02-15 10:38:04 PST 
Attachment 127197 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2

Updating OpenSource
git.webkit.org[0: 17.254.20.231]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)
Died at Tools/Scripts/update-webkit line 162.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Adam Roben (:aroben) 2012-02-15 10:45:44 PST 
Comment on attachment 127197 [details]
Patch

Can we remove ScrollAnimator::handleGestureEvent?
Comment 8 Anders Carlsson 2012-02-15 10:54:19 PST 
Committed r107823: <http://trac.webkit.org/changeset/107823>