Bug 78660 - [BlackBerry] Upstream WebPageClient.h
Summary: [BlackBerry] Upstream WebPageClient.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-02-14 18:52 PST by Leo Yang
Modified: 2012-02-15 18:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.89 KB, patch)
2012-02-14 19:02 PST, Leo Yang 		rwlbuis: review-
Details | Formatted Diff | Diff
Patch v2 (18.28 KB, patch)
2012-02-14 22:25 PST, Leo Yang 		no flags Details | Formatted Diff | Diff
Patch v3 (18.28 KB, patch)
2012-02-14 22:30 PST, Leo Yang 		tonikitoo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-02-14 18:52:12 PST 
WebKit/blackberry/Api/WebPageClient.h is an interface between the client of a WebPage and the WebPage it self.
Comment 1 Leo Yang 2012-02-14 19:02:39 PST 
Created attachment 127101 [details]
Patch
Comment 2 Rob Buis 2012-02-14 19:17:28 PST 
Comment on attachment 127101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127101&action=review

Looks good, but still some things to fix.

> Source/WebKit/blackberry/Api/WebPageClient.h:32
> +#include <BlackBerryPlatformWindow.h>

Are all of the above needed?

> Source/WebKit/blackberry/Api/WebPageClient.h:34
> +#include <pthread.h>

Does not seem needed?

> Source/WebKit/blackberry/Api/WebPageClient.h:45
> +class GeoTracker;

Not needed?
Comment 3 Leo Yang 2012-02-14 22:25:17 PST 
Created attachment 127115 [details]
Patch v2

Cleanup some unnecessary header inclusion.
Comment 4 Leo Yang 2012-02-14 22:30:00 PST 
Created attachment 127116 [details]
Patch v3
Comment 5 WebKit Review Bot 2012-02-15 03:42:17 PST 
Attachment 127115 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Leo Yang 2012-02-15 18:02:54 PST 
Committed r107863: <http://trac.webkit.org/changeset/107863>