Bug 78658 - platformUserPreferredLanguages is leaking all of the language codes
Summary: platformUserPreferredLanguages is leaking all of the language codes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2012-02-14 18:24 PST by Mark Rowe (bdash)
Modified: 2012-02-14 19:05 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (4.10 KB, patch)
2012-02-14 18:29 PST, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2012-02-14 18:24:35 PST 
createHTTPStyleLanguageCode returns a newly-allocated NSString. The caller does nothing to release this string, causing a leak.
Comment 1 Mark Rowe (bdash) 2012-02-14 18:29:44 PST 
Created attachment 127097 [details]
Patch v1
Comment 2 Darin Adler 2012-02-14 18:33:09 PST 
Comment on attachment 127097 [details]
Patch v1

I probably would have made even more of the code use String, but this looks like a fine fix. r=me
Comment 3 WebKit Review Bot 2012-02-14 19:05:03 PST 
Comment on attachment 127097 [details]
Patch v1

Clearing flags on attachment: 127097

Committed r107771: <http://trac.webkit.org/changeset/107771>
Comment 4 WebKit Review Bot 2012-02-14 19:05:07 PST 
All reviewed patches have been landed.  Closing bug.