Bug 78644 - [BlackBerry] Upstream remaining classes in Api
Summary: [BlackBerry] Upstream remaining classes in Api
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 15:38 PST by Rob Buis
Modified: 2012-02-15 16:41 PST (History)
2 users (show)

See Also:

Attachments
Patch (13.55 KB, patch)
2012-02-14 15:40 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2012-02-15 10:35 PST, Rob Buis 		tonikitoo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-02-14 15:38:18 PST 
Upstream leftovers.
Comment 1 Rob Buis 2012-02-14 15:40:38 PST 
Created attachment 127065 [details]
Patch
Comment 2 Rob Buis 2012-02-14 15:41:17 PST 
Add Antonio.
Comment 3 Antonio Gomes 2012-02-14 15:55:13 PST 
Comment on attachment 127065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127065&action=review

BlackBerryContext is a very general name, lets keep it in mind for the future :)

> Source/WebKit/blackberry/Api/BlackBerryGlobal.h:28
> +#ifdef _MSC_VER
> +    #ifdef BUILD_WEBKIT
> +        #define BLACKBERRY_EXPORT __declspec(dllexport)
> +    #else
> +        #define BLACKBERRY_EXPORT __declspec(dllimport)
> +    #endif
> +#elif defined(__QNXNTO__) && defined(BUILD_WEBKIT)

do we really care?

> Source/WebKit/blackberry/Api/BlackBerryGlobal.h:32
> +#else
> +    #define BLACKBERRY_EXPORT
> +#endif

ditto
Comment 4 Rob Buis 2012-02-15 10:35:28 PST 
Created attachment 127196 [details]
Patch
Comment 5 WebKit Review Bot 2012-02-15 10:37:32 PST 
Attachment 127196 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2

Updating OpenSource
git.webkit.org[0: 17.254.20.231]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)
Died at Tools/Scripts/update-webkit line 162.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Rob Buis 2012-02-15 16:41:26 PST 
Landed in r107855.