RESOLVED FIXED78644
[BlackBerry] Upstream remaining classes in Api 
https://bugs.webkit.org/show_bug.cgi?id=78644
Summary [BlackBerry] Upstream remaining classes in Api
Rob Buis
Reported 2012-02-14 15:38:18 PST
Upstream leftovers.
Attachments
Patch (13.55 KB, patch)
2012-02-14 15:40 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2012-02-15 10:35 PST, Rob Buis 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-02-14 15:40:38 PST
Created attachment 127065 [details] Patch
Rob Buis
Comment 2 2012-02-14 15:41:17 PST
Add Antonio.
Antonio Gomes
Comment 3 2012-02-14 15:55:13 PST
Comment on attachment 127065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127065&action=review BlackBerryContext is a very general name, lets keep it in mind for the future :) > Source/WebKit/blackberry/Api/BlackBerryGlobal.h:28 > +#ifdef _MSC_VER > + #ifdef BUILD_WEBKIT > + #define BLACKBERRY_EXPORT __declspec(dllexport) > + #else > + #define BLACKBERRY_EXPORT __declspec(dllimport) > + #endif > +#elif defined(__QNXNTO__) && defined(BUILD_WEBKIT) do we really care? > Source/WebKit/blackberry/Api/BlackBerryGlobal.h:32 > +#else > + #define BLACKBERRY_EXPORT > +#endif ditto
Rob Buis
Comment 4 2012-02-15 10:35:28 PST
Created attachment 127196 [details] Patch
WebKit Review Bot
Comment 5 2012-02-15 10:37:32 PST
Attachment 127196 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 6 2012-02-15 16:41:26 PST
Landed in r107855.
Note You need to log in before you can comment on or make changes to this bug.