Bug 78640 - NRWT is broken for the default port
Summary: NRWT is broken for the default port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 15:04 PST by Dirk Pranke
Modified: 2012-02-14 15:20 PST (History)
0 users

See Also:


Attachments
Patch (1.89 KB, patch)
2012-02-14 15:09 PST, Dirk Pranke
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-02-14 15:04:55 PST
NRWT is broken for the default port
Comment 1 Dirk Pranke 2012-02-14 15:09:25 PST
Created attachment 127054 [details]
Patch
Comment 2 Tony Chang 2012-02-14 15:11:25 PST
Comment on attachment 127054 [details]
Patch

Can you add a unit test that passes self._options that matches what's passed in by the default port?  Or just passes in self._options.platform.
Comment 3 Dirk Pranke 2012-02-14 15:17:09 PST
(In reply to comment #2)
> (From update of attachment 127054 [details])
> Can you add a unit test that passes self._options that matches what's passed in by the default port?  Or just passes in self._options.platform.

Yeah, although it'll be a little bit ugly, so I'll add that as a separate patch on a separate bug to not hold this up or confuse it.
Comment 4 Dirk Pranke 2012-02-14 15:20:37 PST
Committed r107746: <http://trac.webkit.org/changeset/107746>