Bug 78637 - Node::isContentEditable should only update styles, not layout
Summary: Node::isContentEditable should only update styles, not layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 14:55 PST by James Robinson
Modified: 2012-02-21 19:35 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2012-02-14 15:27 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-02-14 14:55:50 PST
Node::isContentEditable should only update styles, not layout
Comment 1 James Robinson 2012-02-14 15:27:01 PST
Created attachment 127058 [details]
Patch
Comment 2 James Robinson 2012-02-14 15:29:49 PST
The updateLayout..() call in handleMousePressEvent() is because the code was previously relying on an isContentEditable() call to update layout.
Comment 3 Ryosuke Niwa 2012-02-14 15:39:32 PST
Comment on attachment 127058 [details]
Patch

Looks reasonable to me.
Comment 4 WebKit Review Bot 2012-02-21 19:35:19 PST
Comment on attachment 127058 [details]
Patch

Clearing flags on attachment: 127058

Committed r108436: <http://trac.webkit.org/changeset/108436>
Comment 5 WebKit Review Bot 2012-02-21 19:35:24 PST
All reviewed patches have been landed.  Closing bug.