Bug 78635 – [UNIX] Plugin information fields are not interpreted as UTF-8

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Diego Escalante Urrelo]

Concrete test case: totem plugin for DiVX is named:
DivX® Web Player

But WebKitGTK+ reads it like this:
DivX® Web Player

The original string in totem source is:

browser-plugin/totemPlugin.cpp:
=8<=======
static const char kPluginDescription[] =
#elif defined(TOTEM_MULLY_PLUGIN)
  "DivX\xC2\xAE Web Player";
=8<=======

The value is handled to WebKitGTK+ by the GetValue implementation here:

browser-plugin/totemPluginGlue.cpp:
=8<=======
static NPError
totem_plugin_get_value (NPP instance,
                        NPPVariable variable,
                        void *value)
        case NPPVpluginNameString:
                *((char **)value) = totemPlugin::PluginDescription ();
                break;
=8<=======

[Martin Robinson]

This appears to be a problem with all Unixy-non-Chromium ports.

[Martin Robinson]

Created attachment 127690 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 127690 [details]
Patch

Makes sense. Diego will be happy!

[WebKit Review Bot]

Comment on attachment 127690 [details]
Patch

Clearing flags on attachment: 127690

Committed r108281: <http://trac.webkit.org/changeset/108281>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.