Bug 78635 - [UNIX] Plugin information fields are not interpreted as UTF-8
Summary: [UNIX] Plugin information fields are not interpreted as UTF-8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 14:38 PST by Diego Escalante Urrelo
Modified: 2012-02-20 18:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.34 KB, patch)
2012-02-17 20:38 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Escalante Urrelo 2012-02-14 14:38:52 PST 
Concrete test case: totem plugin for DiVX is named:
DivX® Web Player

But WebKitGTK+ reads it like this:
DivX® Web Player

The original string in totem source is:

browser-plugin/totemPlugin.cpp:
=8<=======
static const char kPluginDescription[] =
#elif defined(TOTEM_MULLY_PLUGIN)
  "DivX\xC2\xAE Web Player";
=8<=======

The value is handled to WebKitGTK+ by the GetValue implementation here:

browser-plugin/totemPluginGlue.cpp:
=8<=======
static NPError
totem_plugin_get_value (NPP instance,
                        NPPVariable variable,
                        void *value)
        case NPPVpluginNameString:
                *((char **)value) = totemPlugin::PluginDescription ();
                break;
=8<=======
Comment 1 Martin Robinson 2012-02-17 20:31:09 PST 
This appears to be a problem with all Unixy-non-Chromium ports.
Comment 2 Martin Robinson 2012-02-17 20:38:52 PST 
Created attachment 127690 [details]
Patch
Comment 3 Gustavo Noronha (kov) 2012-02-20 17:56:27 PST 
Comment on attachment 127690 [details]
Patch

Makes sense. Diego will be happy!
Comment 4 WebKit Review Bot 2012-02-20 18:19:21 PST 
Comment on attachment 127690 [details]
Patch

Clearing flags on attachment: 127690

Committed r108281: <http://trac.webkit.org/changeset/108281>
Comment 5 WebKit Review Bot 2012-02-20 18:19:26 PST 
All reviewed patches have been landed.  Closing bug.