[BlackBerry] Upstreaming WebSettings code

[Nima Ghanavatian]

This includes WebSettings.cpp, WebSettings.h and WebSettings_p.h

[Nima Ghanavatian]

Created attachment 127049 [details]
Patch

[Jacky Jiang]

(In reply to comment #1)
> Created an attachment (id=127049) [details]
> Patch

I already created the bug https://bugs.webkit.org/show_bug.cgi?id=74379 before, you can mark either of  this as dup if you'd like.

[Rob Buis]

Comment on attachment 127049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127049&action=review

> Source/WebKit/blackberry/Api/WebSettings.cpp:29
> +#include <wtf/Vector.h>

Are all these needed?

> Source/WebKit/blackberry/Api/WebSettings.cpp:590
> +// Whether to include pattern: in the list of string patterns

period.

> Source/WebKit/blackberry/Api/WebSettings.h:51
> +    WebSettings(const WebSettings&);

More common to put private section at the end.

> Source/WebKit/blackberry/Api/WebSettings_p.h:25
> +#include <wtf/text/StringHash.h>

Needed?

> Source/WebKit/blackberry/Api/WebSettings_p.h:67
> +        WTF::HashMap<WTF::String, PrimitiveValue> primitiveValues;

You do not need WTF prefix on HashMap.

[Nima Ghanavatian]

Created attachment 127072 [details]
Patch

[Nima Ghanavatian]

Created attachment 127074 [details]
Patch

[Rob Buis]

Comment on attachment 127074 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 127074 [details]
Patch

Clearing flags on attachment: 127074

Committed r107764: <http://trac.webkit.org/changeset/107764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jacky Jiang]

*** Bug 74379 has been marked as a duplicate of this bug. ***