See: http://code.google.com/p/chromium/issues/detail?id=45747
Created attachment 127017 [details] Patch
LGTM
Looks good. r=me
Comment on attachment 127017 [details] Patch Rejecting attachment 127017 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [CMake] Move RunLoop to WebCore/platform When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/11518869
Created attachment 127202 [details] Patch
Comment on attachment 127202 [details] Patch Rejecting attachment 127202 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11528304
Comment on attachment 127202 [details] Patch Still looks good. r=me
Comment on attachment 127202 [details] Patch Rejecting attachment 127202 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: --chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Full output: http://queues.webkit.org/results/11526385
Comment on attachment 127202 [details] Patch Clearing flags on attachment: 127202 Committed r107864: <http://trac.webkit.org/changeset/107864>
All reviewed patches have been landed. Closing bug.
Committed r114398: <http://trac.webkit.org/changeset/114398>