RESOLVED FIXED 78622
IndexedDB: Invalid dates should not be valid keys 
https://bugs.webkit.org/show_bug.cgi?id=78622
Summary IndexedDB: Invalid dates should not be valid keys
Joshua Bell
Reported 2012-02-14 11:58:37 PST
IndexedDB: Invalid dates should not be valid keys
Attachments
Patch (6.25 KB, patch)
2012-02-14 11:59 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.42 KB, patch)
2012-02-14 13:36 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-02-14 11:59:54 PST
Created attachment 127011 [details] Patch
Joshua Bell
Comment 2 2012-02-14 12:02:05 PST
I noticed this special case and filed a bug against the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15987 This edge case could make the IndexedDB implementation misbehave, since NaNs don't order sensibly and could make insertion and iterators sad pandas.
Tony Chang
Comment 3 2012-02-14 13:16:32 PST
Comment on attachment 127011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127011&action=review > Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:49 > - if (value->IsDate()) > + if (value->IsDate() && !isnan(value->NumberValue())) Should this file explicitly include wtf/MthExtras.h for isnan? It looks like this code already uses it.
Joshua Bell
Comment 4 2012-02-14 13:33:00 PST
(In reply to comment #3) > Should this file explicitly include wtf/MthExtras.h for isnan? It looks like this code already uses it. Good call, adding it.
Joshua Bell
Comment 5 2012-02-14 13:36:12 PST
Created attachment 127033 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-02-14 14:31:47 PST
Comment on attachment 127033 [details] Patch for landing Clearing flags on attachment: 127033 Committed r107738: <http://trac.webkit.org/changeset/107738>
WebKit Review Bot
Comment 7 2012-02-14 14:31:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.