WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78605
Separate mimetype and file extension mapping API from WebKit/blackberry/Api/WebKitTextCodec and complete it.
https://bugs.webkit.org/show_bug.cgi?id=78605
Summary
Separate mimetype and file extension mapping API from WebKit/blackberry/Api/W...
Lyon Chen
Reported
2012-02-14 07:52:44 PST
Right now there is an getExtensionForMimeType() in WebKitTextCodec, it should be in its own files and another matching function, getMimeTypeFromExtension() is needed.
Attachments
Patch for 78605.
(6.95 KB, patch)
2012-02-14 11:41 PST
,
Lyon Chen
rwlbuis
: review-
Details
Formatted Diff
Diff
Patch for 78605 with updated ChangeLog
(6.96 KB, patch)
2012-02-14 12:22 PST
,
Lyon Chen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Lyon Chen
Comment 1
2012-02-14 11:41:57 PST
Created
attachment 127007
[details]
Patch for 78605.
Rob Buis
Comment 2
2012-02-14 12:00:05 PST
Comment on
attachment 127007
[details]
Patch for 78605. View in context:
https://bugs.webkit.org/attachment.cgi?id=127007&action=review
ChangeLog still needs some fixing
> Source/WebKit/ChangeLog:4 > + Now the MIME type and file extension mapping API are in WebKitMIMETypeConverter.
The explanation should go below the Reviewed By line.
> Source/WebKit/ChangeLog:17 > + * blackberry/CMakeListsBlackBerry.txt:
The ChangeLog does not include all changes below.
Lyon Chen
Comment 3
2012-02-14 12:22:44 PST
Created
attachment 127015
[details]
Patch for 78605 with updated ChangeLog
Rob Buis
Comment 4
2012-02-14 12:28:10 PST
Comment on
attachment 127015
[details]
Patch for 78605 with updated ChangeLog Looks good.
WebKit Review Bot
Comment 5
2012-02-14 13:17:18 PST
Comment on
attachment 127015
[details]
Patch for 78605 with updated ChangeLog Clearing flags on attachment: 127015 Committed
r107730
: <
http://trac.webkit.org/changeset/107730
>
WebKit Review Bot
Comment 6
2012-02-14 13:17:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug