Bug 7858 – REGRESSION: New text field doesn't recognize the read only attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Chris Petersen]

New text input fields ignore the read only attribute. When this attribute is specified, the input field can't be edited. However with a new text field, I can edit it even when this attribute is enabled.

[Chris Petersen]

Created attachment 7173 [details]
Sample test case that uses readonly attribute

[Chris Petersen]

This issue has been filed in Radar as <rdar://problem/4483359>

[Adele Peterson]

Bumping to P1 since this causes a text field regression

[Tim Omernick]

Created attachment 7414 [details]
Patch to fix test case

[Maciej Stachowiak]

Comment on attachment 7414 [details]
Patch to fix test case

Does this handle dynamic updates to the readonly attribute correctly? Make sure to test that. I'm not sure if it will. The change needs to happen after style attached to be an effective test, so maybe a button on the side to toggle readonly-ness.

When you do land this, make sure to land the test case as well.

[Tim Omernick]

(In reply to comment #5)
> (From update of attachment 7414 [details] [edit])
> Does this handle dynamic updates to the readonly attribute correctly? Make sure
> to test that. I'm not sure if it will.

Yes, dynamic updates to the readonly property work just fine.  This is because we reflect the element's changes in updateFromElement().  This is how the old text field worked.

[Adele Peterson]

Comment on attachment 7414 [details]
Patch to fix test case

Use READ_WRITE_PLAINTEXT_ONLY instead of READ_WRITE

[Tim Omernick]

Created attachment 7421 [details]
Patch to only allow plain text; also fixed assertion

[Adele Peterson]

Comment on attachment 7421 [details]
Patch to only allow plain text; also fixed assertion

r=me. thanks tim!

[Tim Omernick]

Fix landed to TOT, revision 13617.