Bug 78578 - There is no complete test cases of optional arguments for MediaStream API and PeerConnection
Summary: There is no complete test cases of optional arguments for MediaStream API and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 23:08 PST by Yanbin
Modified: 2012-02-20 21:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (21.04 KB, application/octet-stream)
2012-02-14 21:23 PST, Yanbin
no flags Details
Patch (22.75 KB, patch)
2012-02-15 18:12 PST, Yanbin
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
new patch (22.94 KB, patch)
2012-02-20 03:26 PST, Yanbin
no flags Details | Formatted Diff | Diff
Patch for landing (22.96 KB, patch)
2012-02-20 19:57 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yanbin 2012-02-13 23:08:26 PST
There are only some tests on  /third_party/WebKit/LaoutTests/fast/mediastreams to testing optional argument for addstream function . It only don't cover all possible input parameters scenarios and other functions defined on http://www.w3.org/TR/webrtc/.
I will deliver a new patch for those test cases definition.
Comment 1 Yanbin 2012-02-14 21:23:52 PST
Created attachment 127111 [details]
Patch

Patch
Comment 2 Tommy Widenflycht 2012-02-15 00:42:39 PST
Hmm, it seems that the patch didn't upload correctly.
Did you use "Tools/Scripts/webkit-patch upload"?
Comment 3 Yanbin 2012-02-15 18:12:19 PST
Created attachment 127288 [details]
Patch

updated patch
Comment 4 Adam Barth 2012-02-19 18:15:23 PST
Comment on attachment 127288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127288&action=review

> LayoutTests/ChangeLog:4
> + 2012-02-16  Yanbin Zhang  <yanbin.zhang@intel.com>
> +     There is no complete test cases of optional arguments for MediaStream API and PeerConnection
> +     https://bugs.webkit.org/show_bug.cgi?id=78578
> +     

It looks like you've got a slight formatting error in your ChangeLog.  I can correct it for you when landing this patch.
Comment 5 Yanbin 2012-02-19 18:16:36 PST
Many thanks Adam
Comment 6 WebKit Review Bot 2012-02-19 19:20:25 PST
Comment on attachment 127288 [details]
Patch

Attachment 127288 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11542993

New failing tests:
fast/mediastream/peerconnection-Attributes.html
Comment 7 Yanbin 2012-02-20 03:26:05 PST
Created attachment 127798 [details]
new patch


Updated patch for command #6.
For failure of command #6, because some test cases for ICE State defined at http://www.w3.org/TR/webrtc/ were run . It seem those features don't implemented now. 
FAIL pc.ICE_GATHERING == 0x100  should be true. Was false.
FAIL pc.ICE_WAITING == 0x200 should be true. Was false.
FAIL pc.ICE_CHECKING == 0x300 should be true. Was false.
FAIL pc.ICE_CONNECTED == 0x400 should be true. Was false.
FAIL pc.ICE_COMPLETED == 0x500 should be true. Was false.
FAIL pc.ICE_FAILED == 0x600 should be true. Was false.
FAIL pc.ICE_CLOSED == 0x700 should be true. Was false.
FAIL pc.SDP_IDLE == 0x1000 should be true. Was false.
FAIL pc.SDP_WAITING == 0x2000 should be true. Was false.
FAIL pc.SDP_GLARE ==0x3000 should be true. Was false.

test results for those test cases at peerconnection-Attributes-expected.txt file have been modified to FAIL .
Comment 8 Adam Barth 2012-02-20 19:50:34 PST
Comment on attachment 127798 [details]
new patch

I'll fix the ChangeLog formatting for you.  In general, prepare-ChangeLog should give you the right formatting.
Comment 9 Adam Barth 2012-02-20 19:57:31 PST
Created attachment 127903 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-02-20 21:24:50 PST
Comment on attachment 127903 [details]
Patch for landing

Clearing flags on attachment: 127903

Committed r108299: <http://trac.webkit.org/changeset/108299>
Comment 11 WebKit Review Bot 2012-02-20 21:24:57 PST
All reviewed patches have been landed.  Closing bug.