Bug 78573 - Rename Bump* to Copy*
Summary: Rename Bump* to Copy*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 78610
  Show dependency treegraph
 
Reported: 2012-02-13 21:12 PST by Mark Hahnenberg
Modified: 2012-02-17 12:09 PST (History)
7 users (show)

See Also:


Attachments
Patch (66.83 KB, patch)
2012-02-13 21:39 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Fix qt build (67.38 KB, patch)
2012-02-13 22:15 PST, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-02-13 21:12:41 PST
In keeping with the naming theme of MarkedSpace et al, we should rename BumpSpace et al to CopySpace, etc.
Comment 1 Mark Hahnenberg 2012-02-13 21:39:28 PST
Created attachment 126905 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-13 21:41:32 PST
Attachment 126905 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/heap/Heap.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2012-02-13 22:15:37 PST
Created attachment 126907 [details]
Fix qt build
Comment 4 WebKit Review Bot 2012-02-13 22:18:58 PST
Attachment 126907 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/heap/Heap.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2012-02-16 16:53:45 PST
Comment on attachment 126907 [details]
Fix qt build

I think the true analogue to "MarkedSpace" would actually be "CopiedSpace". Maybe you can make that change before committing.

rs=me
Comment 6 Mark Hahnenberg 2012-02-17 12:09:29 PST
Committed r108107: <http://trac.webkit.org/changeset/108107>