RESOLVED FIXED 78573
Rename Bump* to Copy* 
https://bugs.webkit.org/show_bug.cgi?id=78573
Summary Rename Bump* to Copy*
Mark Hahnenberg
Reported 2012-02-13 21:12:41 PST
In keeping with the naming theme of MarkedSpace et al, we should rename BumpSpace et al to CopySpace, etc.
Attachments
Patch (66.83 KB, patch)
2012-02-13 21:39 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix qt build (67.38 KB, patch)
2012-02-13 22:15 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-02-13 21:39:28 PST
Created attachment 126905 [details] Patch
WebKit Review Bot
Comment 2 2012-02-13 21:41:32 PST
Attachment 126905 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/heap/Heap.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 3 2012-02-13 22:15:37 PST
Created attachment 126907 [details] Fix qt build
WebKit Review Bot
Comment 4 2012-02-13 22:18:58 PST
Attachment 126907 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/heap/Heap.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2012-02-16 16:53:45 PST
Comment on attachment 126907 [details] Fix qt build I think the true analogue to "MarkedSpace" would actually be "CopiedSpace". Maybe you can make that change before committing. rs=me
Mark Hahnenberg
Comment 6 2012-02-17 12:09:29 PST
Committed r108107: <http://trac.webkit.org/changeset/108107>
Note You need to log in before you can comment on or make changes to this bug.