Bug 78568 - webkitpy: clean up options, port handling in manager_worker_broker
Summary: webkitpy: clean up options, port handling in manager_worker_broker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 78171
  Show dependency treegraph
 
Reported: 2012-02-13 19:33 PST by Dirk Pranke
Modified: 2012-02-14 16:42 PST (History)
4 users (show)

See Also:


Attachments
Patch (16.01 KB, patch)
2012-02-13 19:35 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
patch for landing (15.88 KB, patch)
2012-02-14 16:33 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-02-13 19:33:27 PST
webkitpy: clean up options, port handling in manager_worker_broker
Comment 1 Dirk Pranke 2012-02-13 19:35:29 PST
Created attachment 126891 [details]
Patch
Comment 2 Dirk Pranke 2012-02-13 19:36:03 PST
Tony, please take a look (after 78171)?
Comment 3 Tony Chang 2012-02-14 16:13:53 PST
Comment on attachment 126891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126891&action=review

> Tools/ChangeLog:14
> +        * Scripts/webkitpy/layout_tests/controllers/manager.py:
> +        (Manager._run_tests):
> +        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
> +        (get):

Nit: Some annotations would have made this clearer.  Part of this patch is removing unused functions/parameters.  Some of it is moving around whether we pass a parameter to a constructor or to a specific method.
Comment 4 Dirk Pranke 2012-02-14 16:18:33 PST
(In reply to comment #3)
> Nit: Some annotations would have made this clearer.  Part of this patch is removing unused functions/parameters.  Some of it is moving around whether we pass a parameter to a constructor or to a specific method.

Sorry, I've never been in the habit of function-level annotations in the ChangeLogs (they're always noise to me). I will try to be better about such things in the future.
Comment 5 Dirk Pranke 2012-02-14 16:33:51 PST
Created attachment 127076 [details]
patch for landing
Comment 6 Dirk Pranke 2012-02-14 16:36:35 PST
Committed r107754: <http://trac.webkit.org/changeset/107754>