webkitpy: clean up options, port handling in manager_worker_broker
Created attachment 126891 [details] Patch
Tony, please take a look (after 78171)?
Comment on attachment 126891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126891&action=review > Tools/ChangeLog:14 > + * Scripts/webkitpy/layout_tests/controllers/manager.py: > + (Manager._run_tests): > + * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: > + (get): Nit: Some annotations would have made this clearer. Part of this patch is removing unused functions/parameters. Some of it is moving around whether we pass a parameter to a constructor or to a specific method.
(In reply to comment #3) > Nit: Some annotations would have made this clearer. Part of this patch is removing unused functions/parameters. Some of it is moving around whether we pass a parameter to a constructor or to a specific method. Sorry, I've never been in the habit of function-level annotations in the ChangeLogs (they're always noise to me). I will try to be better about such things in the future.
Created attachment 127076 [details] patch for landing
Committed r107754: <http://trac.webkit.org/changeset/107754>