Bug 78566 - [CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
Summary: [CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 19:25 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2012-02-14 15:26 PST (History)
0 users

See Also:


Attachments
Patch (3.65 KB, patch)
2012-02-13 19:26 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch for landing (3.63 KB, patch)
2012-02-14 15:25 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-02-13 19:25:26 PST
[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-02-13 19:26:18 PST
Created attachment 126890 [details]
Patch
Comment 2 Daniel Bates 2012-02-14 15:16:02 PST
Comment on attachment 126890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126890&action=review

> Source/cmake/FindEFL.cmake:19
> +    MESSAGE(FATAL_ERROR "edje_cc could not be found")

Nit: Should there be a space between MESSAGE and '('? We seem to be inconsistent throughout the CMake build system with respect to our function call notation.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-02-14 15:25:18 PST
Created attachment 127056 [details]
Patch for landing
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-02-14 15:26:36 PST
Committed r107747: <http://trac.webkit.org/changeset/107747>