Bug 78560 - The tile cache layer should have its background set to the page background
Summary: The tile cache layer should have its background set to the page background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 18:27 PST by Anders Carlsson
Modified: 2012-02-14 15:46 PST (History)
0 users

See Also:

Attachments
Patch (4.73 KB, patch)
2012-02-13 18:29 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-13 18:27:41 PST 
The tile cache layer should have its background set to the page background
Comment 1 Anders Carlsson 2012-02-13 18:29:34 PST 
Created attachment 126883 [details]
Patch
Comment 2 Anders Carlsson 2012-02-13 18:36:24 PST 
Committed r107657: <http://trac.webkit.org/changeset/107657>
Comment 3 Darin Adler 2012-02-14 15:46:19 PST 
Comment on attachment 126883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126883&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1658
> +    if (!backgroundColor.isValid() || backgroundColor.hasAlpha())

The isValid check is redundant because invalid colors always have alpha of 0 so return true for hasAlpha.