Bug 78554 – Refactor ClipboardMac class to use PlatformStrategies

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

This bug track another step in the direction of removing access to NSPasteboard from the WebProcess.
The Mac implementation of the Clipboard class needs to be redesigned to use a platform strategy that can provide different implementations for WebKit and WebKit2.

[Enrica Casucci]

Created attachment 126872 [details]
Patch

[Anders Carlsson]

Comment on attachment 126872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126872&action=review

> Source/WebCore/platform/PasteboardStrategy.h:46
> +    virtual const String uniqueName() = 0;

This doesn't need to return a const String.

> Source/WebCore/platform/PlatformPasteboard.h:43
> +    static const String uniqueName();

Ditto.

> Source/WebCore/platform/PlatformPasteboard.h:49
> +    int changeCount();

Can this member function be const?

> Source/WebCore/platform/mac/ClipboardMac.mm:73
> +static const String cocoaTypeFromHTMLClipboardType(const String& type)

No need for const.

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 126872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126872&action=review
> 
> > Source/WebCore/platform/PasteboardStrategy.h:46
> > +    virtual const String uniqueName() = 0;
> 
> This doesn't need to return a const String.
> 
> > Source/WebCore/platform/PlatformPasteboard.h:43
> > +    static const String uniqueName();
> 
> Ditto.
> 
> > Source/WebCore/platform/PlatformPasteboard.h:49
> > +    int changeCount();
> 
> Can this member function be const?
> 
> > Source/WebCore/platform/mac/ClipboardMac.mm:73
> > +static const String cocoaTypeFromHTMLClipboardType(const String& type)
> 
> No need for const.

Thanks for the review! I'll address your comments.

[Enrica Casucci]

http://trac.webkit.org/changeset/107844