Bug 78552 - SharedBuffer's Vector<RetainPtr<CFDataRef> > should have a typedef
Summary: SharedBuffer's Vector<RetainPtr<CFDataRef> > should have a typedef
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2012-02-13 16:54 PST by Benjamin Poulain
Modified: 2019-08-07 11:51 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-02-13 16:54:22 PST 
From https://bugs.webkit.org/show_bug.cgi?id=77718

> Source/WebCore/platform/cf/SharedBufferCF.cpp:121
> +    Vector<RetainPtr<CFDataRef> >::const_iterator end = m_dataArray.end();

Nit: Might be nice to have a typedef for Vector<RetainPtr<CFDataRef> >.
Comment 1 David Kilzer (:ddkilzer) 2019-08-07 11:51:34 PDT 
SharedBufferCF.cpp no longer has this code, and the only data structure it iterates over:

    mutable DataSegmentVector m_segments;

Already has the equivalent of a typedef:

    using DataSegmentVector = Vector<DataSegmentVectorEntry, 1>;
    DataSegmentVector::const_iterator begin() const { return m_segments.begin(); }
    DataSegmentVector::const_iterator end() const { return m_segments.end(); }

So moving to RESOLVED/CONFIGURATION CHANGED.