Bug 78544 - fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue
Summary: fast/text/atsui-multiple-renderers.html and related report IMAGE failure on c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 15:18 PST by noel gordon
Modified: 2012-08-07 00:09 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.55 KB, patch)
2012-02-13 15:37 PST, noel gordon
no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2012-02-13 16:15 PST, noel gordon
no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2012-02-13 19:04 PST, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-02-13 15:18:18 PST
Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

I have seen those same results for over 4 months, and they seem to slow down the commit queue.  We should just add the expected failures until someone who cares/knows about Thai and Atsui rendering cares to investigate.
Comment 1 noel gordon 2012-02-13 15:37:02 PST
Created attachment 126849 [details]
Patch
Comment 2 noel gordon 2012-02-13 16:09:04 PST
Tests PASS locally for me on linux.  Suspect the commit queue does not have the expected fonts installed.
Comment 3 noel gordon 2012-02-13 16:10:20 PST
Mark the tests: PASS (local) + IMAGE+TEXT (commit-queue)
Comment 4 noel gordon 2012-02-13 16:15:55 PST
Created attachment 126858 [details]
Patch
Comment 5 noel gordon 2012-02-13 19:04:24 PST
Created attachment 126886 [details]
Patch
Comment 6 noel gordon 2012-02-13 19:56:58 PST
(In reply to comment #5)
> Created an attachment (id=126886) [details]
> Patch

Ahem, Mark the tests: PASS (local) + IMAGE+TEXT (commit-queue) + IMAGE (commit-queue)
Comment 7 noel gordon 2012-02-13 20:38:21 PST
Comment on attachment 126886 [details]
Patch

Clearing flags on attachment: 126886

Committed r107664: <http://trac.webkit.org/changeset/107664>
Comment 8 noel gordon 2012-02-13 20:38:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 noel gordon 2012-03-07 21:39:00 PST
After http://trac.webkit.org/changeset/109793, commit queue and linux EWS are again reporting 
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE
Comment 10 noel gordon 2012-03-07 21:50:31 PST
After http://trac.webkit.org/changeset/109420,  commit queue and linux EWS are again reporting
   fast/text/international/thai-line-breaks.html = IMAGE
Comment 11 Tony Chang 2012-03-08 10:20:06 PST
This patch is wrong.  These tests should not be in test_expectations.txt.

The ews bots are running a different version of Ubuntu than developers and the waterfall bots.  We want the baselines and expectations to reflect what developers and the waterfall bots run.

It's not a problem that these fail on the ews bots since they are smart enough to ignore these consistent failures.

This problem will go away once we switch to Ubuntu Precise in April/May.
Comment 12 noel gordon 2012-08-07 00:09:45 PDT
Fixed by moving to compute engine.