Bug 78540 - Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Summary: Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 14:39 PST by Eric Seidel (no email)
Modified: 2012-02-14 00:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2012-02-13 14:40 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-02-13 14:39:38 PST
Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Comment 1 Eric Seidel (no email) 2012-02-13 14:40:18 PST
Created attachment 126839 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-13 14:41:17 PST
Someone with familiarity of Skia and the JPEGEncoder should look at this and make sure it's sane.
Comment 3 Adam Barth 2012-02-13 14:44:29 PST
Comment on attachment 126839 [details]
Patch

Looks reasonable.  Noel should double-check.
Comment 4 Eric Seidel (no email) 2012-02-13 14:49:46 PST
Comment on attachment 126839 [details]
Patch

I'd like to wait for his comment before landing.  Would hate to land useless code. :)
Comment 5 noel gordon 2012-02-13 15:05:04 PST
Looks sane tome.
Comment 6 Adam Barth 2012-02-13 15:07:49 PST
Comment on attachment 126839 [details]
Patch

Thanks Noel.
Comment 7 noel gordon 2012-02-14 00:07:01 PST
np, and sane because the little-endian skia-using ports (chrome) use BGRA skia bitmaps, except chrome android where RGBA skia bitmaps are in vogue for some reason - see jpeg decoder fix bug 75861.
Comment 8 WebKit Review Bot 2012-02-14 00:16:53 PST
Comment on attachment 126839 [details]
Patch

Clearing flags on attachment: 126839

Committed r107679: <http://trac.webkit.org/changeset/107679>
Comment 9 WebKit Review Bot 2012-02-14 00:16:57 PST
All reviewed patches have been landed.  Closing bug.