Bug 78536 - Upstream Android's additions to Platform.h
Summary: Upstream Android's additions to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 14:07 PST by Eric Seidel (no email)
Modified: 2012-02-14 00:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2012-02-13 14:08 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-02-13 14:07:50 PST 
Upstream Android's additions to Platform.h
Comment 1 Eric Seidel (no email) 2012-02-13 14:08:31 PST 
Created attachment 126833 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-13 14:09:55 PST 
Android also had some lines:

#define WTF_OS_WIN ERROR "USE WINDOWS WITH OS NOT WIN"
#define WTF_OS_MAC ERROR "USE MAC_OS_X WITH OS NOT MAC"

But they seemed unrelated to android (and likely due to a bad merge), thus I did not upstream them.
Comment 3 Satish Sampath 2012-02-13 14:14:20 PST 
Looks good to me
Comment 4 WebKit Review Bot 2012-02-14 00:06:06 PST 
Comment on attachment 126833 [details]
Patch

Clearing flags on attachment: 126833

Committed r107678: <http://trac.webkit.org/changeset/107678>
Comment 5 WebKit Review Bot 2012-02-14 00:06:10 PST 
All reviewed patches have been landed.  Closing bug.