Bug 78532 – Last character display for passwords in Android.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ramya Chandrasekaran]

Last character display for passwords in Android.

[Ramya Chandrasekaran]

Created attachment 126829 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Ramya Chandrasekaran]

Created attachment 126835 [details]
Patch

[Adam Barth]

Comment on attachment 126835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review

The rest of the change looks fine.

> Source/WebCore/page/Settings.cpp:233
> +#if OS(ANDROID)
> +    , m_passwordEchoEnabled(true)
> +#else
>      , m_passwordEchoEnabled(false)
> +#endif

This isn't correct.  The Android should change this preference via the Chromium WebKit API.  We use the same initializations across all the ports.

[Kent Tamura]

Comment on attachment 126835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests. (OOPS!)
> +

This line should be removed or modified.

> Tools/DumpRenderTree/chromium/WebPreferences.cpp:248
> +#if OS(ANDROID)
> +    // By default, this is set to true for ANDROID in Settings.cpp.
> +    // This should be false for LayoutTests.
> +    settings->setPasswordEchoEnabled(false);
> +#endif

#if and #endif are not needed.

[Darin Fisher (:fishd, Google)]

Comment on attachment 126835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review

> Source/WebKit/chromium/public/WebSettings.h:135
> +    virtual void setPasswordEchoEnabled(bool) = 0;

API changes LGTM

[Ramya Chandrasekaran]

Created attachment 127035 [details]
Patch

[Adam Barth]

Comment on attachment 127035 [details]
Patch

Looks great.  Thanks!

[WebKit Review Bot]

Comment on attachment 127035 [details]
Patch

Clearing flags on attachment: 127035

Committed r107739: <http://trac.webkit.org/changeset/107739>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.